Upgrade ESLint to v10.4.0 with flat config#3572
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
Core Functionality, CI
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: Upgrades ESLint from v7.32.0 to v10.4.0 and migrates the configuration from the legacy
.eslintrc.jsonformat to the new flat config (eslint.config.js). Also pins all devDependency versions exactly and adds.npmrcwithmin-release-age=3for supply-chain safety.Q: Give a technical rundown of what you have changed (if applicable)
A:
.eslintrc.json— ESLint 10 removed support for the legacy config format entirely.eslint.config.js— Equivalent flat config with the same rules, globals, and ignore patterns. Uses@eslint/jsforrecommendedrules and theglobalspackage for browser globals (replaces"env": { "browser": true }).package.json:eslint:7.32.0→10.4.0@eslint/js:10.0.1globals:17.6.0^or~).(flat config handles ignores internally).npmrc— Setsmin-release-age=3to refuse packages published less than 3 days ago (requires npm 11.10+, currently active in CI on Node 24)..github/workflows/eslint.yml— Changednpx eslint "**/*.js"tonpx eslint .in the report-only job to align with flat config file resolution.package-lock.jsonwith the new dependency tree.Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: Ran both CI jobs locally using
act:lint-all-files— ESLint 10 ran successfully against the full codebase. 5654 pre-existing errors reported (same issues ESLint 7 would flag). Job completed with success (non-blocking,continue-on-error: true).lint-changed-files— No JS files in the test diff, correctly skipped linting. Job completed with success.No new lint errors were introduced by this change. All errors are pre-existing codebase issues.
Wiki Page
N/A — no new user-facing features. The linting infrastructure is transparent to contributors;
npm run lintcontinues to work as before.