Fix incorrect exec transition for cargo_build_script#4040
Open
UebelAndre wants to merge 1 commit into
Open
Conversation
UebelAndre
force-pushed
the
cargo_build_script
branch
from
5a7b1ad to
f0efda9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relying on an exec configuration through targets consumed in
targetleads to the potential forcfg = "exec"to be evaluated differently in the transitive target (in this case,cargo_build_script_runfiles.script) and the consumer (cargo_build_script.data_runfiles). This change moves the script directly back tocargo_build_scriptincfg = "exec"and separately uses acfg = "target"intermediate rule to implement runfiles (solving for bazelbuild/bazel#15486).closes #3201