Split rustdoc test compilation and execution#4034
Draft
UebelAndre wants to merge 1 commit into
Draft
Conversation
UebelAndre
force-pushed
the
rustdoc
branch
5 times, most recently
from
287d94d to
74817a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new
RustdocTestCompileaction which takes advantage of the nightly rustc flag-Zunstable-options --persist-docteststo have rustdoc tests written to disk to be executed in a separate action, similar to a normalrust_testwhich first compiles the test and then executes it in a test action.To use this change a nightly toolchain is required and the use of
--@rules_rust//rust/settings:experimental_compile_rustdoc_tests=True.closes #1431