feat(tools): add MCP tool annotations to all 66 tools#116
Open
basebandit wants to merge 1 commit into
Open
Conversation
4 tasks
a0a1920 to
c9c812e
Compare
5a5c3c7 to
cfa0058
Compare
c9c812e to
b7d02e0
Compare
cfa0058 to
b68ae65
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
readOnlyHint,destructiveHint,idempotentHint,openWorldHint, andtitleannotations to every registered tool, per MCP spec 2025-03-26.A small helper file (
tools/annotations.go) defines four named annotation sets so each call site is one line:readOnlyAnnotationdestructiveAnnotationcreationAnnotationidempotentMutationAnnotationopenWorldHintis true for every tool because the Kubernetes API is an external system.Coverage
66 tools across 11 files annotated. All existing tests pass without modification.
Stacked on
Based on
chore/mcp-go-api-migration(#115). Merge order: #114 → #115 → this.Test plan
go build ./...go vet ./...go test -race ./...