Merged
Conversation
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
danyalprout
approved these changes
Apr 4, 2026
| @@ -71,7 +71,7 @@ pub enum OracleProviderError { | |||
| /// formats fails due to incompatible data structures, missing OP-specific | |||
| /// fields, or version mismatches between block formats. | |||
| #[error("Op block conversion error: {0}")] | |||
Contributor
There was a problem hiding this comment.
The error display string still says "Op block" but the variant and type were renamed to BaseBlock*. Consider updating for consistency:
Suggested change
| #[error("Op block conversion error: {0}")] | |
| #[error("Base block conversion error: {0}")] |
Contributor
Review SummaryStraightforward mechanical rename from FindingsMinor: Stale error display string ( Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames all
OpBlock-prefixed types across the workspace to use aBaseBlockprefix to better reflect the project's identity. This covers the coreBaseBlocktype alias, as well as derived types such asBaseBlockBody,BaseBlockExecutor,BaseBlockExecutorFactory,BaseBlockExecutionCtx,BaseBlockExecutionError,BaseBlockAssembler, andBaseBlockConversionError. All usages in source files and documentation have been updated.