Skip to content

chore(repo): BaseBlock Rename#1920

Merged
refcell merged 2 commits intomainfrom
ab/rename-op-block-to-base-block
Apr 4, 2026
Merged

chore(repo): BaseBlock Rename#1920
refcell merged 2 commits intomainfrom
ab/rename-op-block-to-base-block

Conversation

@refcell
Copy link
Copy Markdown
Contributor

@refcell refcell commented Apr 4, 2026

Summary

Renames all OpBlock-prefixed types across the workspace to use a BaseBlock prefix to better reflect the project's identity. This covers the core BaseBlock type alias, as well as derived types such as BaseBlockBody, BaseBlockExecutor, BaseBlockExecutorFactory, BaseBlockExecutionCtx, BaseBlockExecutionError, BaseBlockAssembler, and BaseBlockConversionError. All usages in source files and documentation have been updated.

@refcell refcell added A-repo Area: general repository changes K-ktlo Kind: keep the lights on, general cleanups M-refactor Meta: refactors code labels Apr 4, 2026
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 4, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
base Ignored Ignored Preview Apr 4, 2026 0:52am

Request Review

@refcell refcell changed the title chore(repo): Rename OpBlock Types To BaseBlock chore(repo): BaseBlock Rename Apr 4, 2026
@refcell refcell requested a review from danyalprout April 4, 2026 00:25
@refcell refcell self-assigned this Apr 4, 2026
@refcell refcell marked this pull request as ready for review April 4, 2026 00:25
@refcell refcell enabled auto-merge April 4, 2026 00:52
@github-actions github-actions bot added the M-prevent-stale Meta: Not Stale label Apr 4, 2026
@refcell refcell added this pull request to the merge queue Apr 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 4, 2026
@refcell refcell enabled auto-merge April 4, 2026 12:52
@@ -71,7 +71,7 @@ pub enum OracleProviderError {
/// formats fails due to incompatible data structures, missing OP-specific
/// fields, or version mismatches between block formats.
#[error("Op block conversion error: {0}")]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error display string still says "Op block" but the variant and type were renamed to BaseBlock*. Consider updating for consistency:

Suggested change
#[error("Op block conversion error: {0}")]
#[error("Base block conversion error: {0}")]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

Review Summary

Straightforward mechanical rename from OpBlock-prefixed types to BaseBlock-prefixed types across the workspace. The rename is comprehensive — no stale OpBlock type references remain in source files.

Findings

Minor: Stale error display string (crates/proof/proof/src/errors.rs:73)
The #[error(...)] string on the renamed BaseBlockConversion variant still reads "Op block conversion error: {0}". Should be updated to "Base block conversion error: {0}" for consistency. (Inline comment posted.)

Notes

  • The three files with asymmetric add/delete counts (validator.rs, l1.rs, builder/core.rs) were inspected — the extra lines are solely from rustfmt re-wrapping longer identifiers. No behavioral changes.
  • Internal field/variable names like op_blocks and insert_op_block were intentionally left unchanged (they're not type names), which is reasonable scope for this PR.
  • The an [BaseBlock]a [BaseBlock] grammar fix on actions/harness/src/node.rs was already flagged by a prior review comment.

@refcell refcell added this pull request to the merge queue Apr 4, 2026
Merged via the queue into main with commit a1ef545 Apr 4, 2026
28 of 29 checks passed
@refcell refcell deleted the ab/rename-op-block-to-base-block branch April 4, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-repo Area: general repository changes K-ktlo Kind: keep the lights on, general cleanups M-prevent-stale Meta: Not Stale M-refactor Meta: refactors code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants