Open
Conversation
Contributor
|
thank you very much @AdityaAudi! I've flagged this for v2 with milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change: Customers passing
timeout=toInvokeConfigwill receive aTypeErroron upgrade. Targeting v2!Summary
Removes the unused
timeoutfield fromInvokeConfigas described in #321The field was passed to
suspend_with_optional_resume_delayas a polling retry delay, but this has no meaningful effect, invoke completion is pushed by the backend, not polled. The field was misleadingly named and did not enforce any actual timeout on the invocation.Changes
config.py- removedtimeout: Durationfield andtimeout_secondsproperty fromInvokeConfigoperation/invoke.py-suspend_with_optional_resume_delaycalled without delay (indefinite suspend)tests/- removedDurationimport, removed/updated all timeout-specific invoke testsdocs/architecture.md- removedtimeout_secondsfromInvokeConfigclass diagramdocs/core/invoke.md- removed all timeout references (terminology, config, error handling, best practices, FAQ, testing)Test plan
hatch test -- -p no:randomly)timeout=incidentally now use defaultInvokeConfig()