fix(commons): keep AWS_SDK_UA_APP_ID idempotent and <=50 chars

[saschabuehrle]

Fixes #5082

This patch makes commons user-agent app-id initialization safe for repeated module loads and compliant with the AWS SDK 50-char limit:

• avoid appending the PT/NO-OP marker when it already exists
• cap the final AWS_SDK_UA_APP_ID value to 50 chars
• add regression tests for idempotency and max-length behavior

Greetings, saschabuehrle

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

[powertools-for-aws-oss-automation]

No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template at .github/PULL_REQUEST_TEMPLATE.md#acknowledgment

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dreamorosi]

Although I don't have a better solution yet - which is why we haven't addressed the issue - I don't think trimming, slicing, and generally doing all these operations every time the module is imported is the way to go.

I'd rather help customers address the root cause of why the module is imported twice - which is bad regardless of the UA length - or give a way to opt out from UA concatenation altogether.

[saschabuehrle]

Thanks for the detailed review. Agreed on the concern about doing normalization work at import time.

I’m going to rework this around an explicit opt-in/guard path so we avoid repeated module-load mutations and keep behavior predictable. I’ll post an updated patch here.

Greetings, saschabuehrle

[saschabuehrle]

Thanks for the review. I agree this needs a different approach than import-time normalization. I’m parking this one while I work out a cleaner opt-in path and will come back with a revised patch.\n\nGreetings, saschabuehrle

[saschabuehrle]

Closing this out for now since the current approach isn't the right direction. I'll reopen with a new patch once I have a cleaner opt-in design that matches the maintainer guidance.\n\nGreetings, saschabuehrle