You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
The OpenAPIMerge.discover() + get_openapi_schema() flow silently swallows handler loading failures in _load_resolver_with_dependencies (merge.py line 228). When a dependent file fails to load (e.g. due to decorators that validate environment variables at import time), the route decorators never execute, and the resulting schema is empty — no paths, no components — with no warning surfaced to the user.
I hit this in aws-lambda-handler-cookbook, where @init_environment_variables(model=MyHandlerEnvVars) (from aws-lambda-env-modeler) on the lambda_handler function validates required env vars at decoration time. When running OpenAPIMerge outside of a Lambda environment (e.g. in CI for static schema generation), this raises a ValueError that gets caught and silently discarded. The @app.post(...) route on the same file never registers, producing a valid but empty OpenAPI schema.
I worked around this by setting dummy env vars before calling discover()/get_openapi_json_schema(), but ideally the library should either:
Surface a visible warning (not just logger.warning) when dependent files fail to load
Raise an error or warn when the final schema contains zero paths after discovery found handler files
Document that handler modules must be side-effect-free at import time for OpenAPIMerge to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #7925
Summary
This PR adds new documentation for OpenAPI.
It also fixes a bug detected by @ran-isenberg during testing with the OpenAPI Merge.
Changes
User experience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.