Open
Conversation
Replaces the bare print() stub with a logging-aware example: - With a config file: loads config and calls util.logging_setup() - Without config: falls back to logging.basicConfig(INFO) Both paths emit a logger.info message so the generated project demonstrates end-to-end logging from the very first run.
…g variants (closes #39) All three config options (yaml, hocon, none) now expose setup_logging() so main.py can call util.setup_logging() unconditionally. Added util__none.py for the no-config case (renamed to util.py by the post-gen hook); updated handle_config() to delete the unused util__* variants; updated tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralised logging setup (closes #39): all config variants now expose a single
util.setup_logging()function somain.pyis uniform regardless of the chosen config format.util__yaml.pyandutil__hocon.pygain asetup_logging()wrapper; a newutil__none.pyprovides a standalonesetup_logging()for the no-config case (renamed toutil.pyby the post-generate hook).