Move the multimap assertions out of api package#15
Open
mattbertolini wants to merge 1 commit intoassertj:mainfrom
Open
Move the multimap assertions out of api package#15mattbertolini wants to merge 1 commit intoassertj:mainfrom
mattbertolini wants to merge 1 commit intoassertj:mainfrom
Conversation
…of the api package.
Member
|
If you're considering simplifying the package structure, you might even consider having all assertion classes at the same level as the entry point classes. Just FYI, In this case, the
Of course, feel free to go with the setup you feel more comfortable with! |
Collaborator
Author
|
I like that structure. I rather it be consistent with other conventions in the org. Better for understanding and contributions. I'll make that change to the PR sometime today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I've started up work on this again, I've realized that there really isn't a need for the
.api.package in this library. I originally was mirroring the eclipse collections package structure but they have an explicitapiandimpllibrary split. There is no such need for this split in the assertions so I am going to shorten the package structure.It will now look like this:
org.assertj.eclipse.collections --> Root package with entry point assertions type and abstract core types
org.assertj.eclipse.collections.multimap --> for Multimap assertions
org.assertj.eclipse.collections.bag
org.assertj.eclipse.collections.set
org.assertj.eclipse.collections.list
org.assertj.eclipse.collections.map
org.assertj.eclipse.collections.primitive --> for primitive collection assertions
org.assertj.eclipse.collections.error --> error support types
There may be some internal subpackages but too early to tell right now.