Bump @types/node from 20.19.37 to 25.9.1 in /apps/desktop#344
Bump @types/node from 20.19.37 to 25.9.1 in /apps/desktop#344dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
PR author is in the excluded authors list. |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review
Scope: 2 file(s), +9 / −9
Verdict: Needs changes
Dependabot bumps @types/node from 20.x to 25.9.1 in apps/desktop only (lockfile included). That is a dev-only types change, but @types/node@25 ships node:sqlite declarations that override the app’s local src/types/node-sqlite.d.ts augmentations. Desktop npm run typecheck then fails with nine errors in recentProjectSummary.ts; CI runs that job (typecheck-desktop).
🐛 Functionality
[High] Desktop typecheck fails after @types/node 25
File: apps/desktop/src/main/services/projects/recentProjectSummary.ts:L49-L116
Issue: @types/node@25 includes node_modules/@types/node/sqlite.d.ts, whose StatementSync.get / .all do not accept generic type parameters and return SQLOutputValue rows. Calls such as .get<{ present?: number }>(tableName) and .all<LaneCountRow>() error with TS2558 (“Expected 0 type arguments, but got 1”) and TS2322/TS2345 on row fields. With @types/node@20, npm run typecheck reports zero errors under src/; with 25.9.1 it reports nine errors, all in this file.
Repro: On the PR branch, cd apps/desktop && npm ci && npm run typecheck.
Fix: Either stay on a Node-22-aligned types line (e.g. @types/node@^22) until sqlite typings are reconciled, or remove/replace src/types/node-sqlite.d.ts and update sqlite call sites to match the official node:sqlite types (cast/narrow SQLOutputValue, drop generic .get<T> / .all<T>).
Notes
- Runtime and CI use Node 22;
@types/node@25describes Node 25 APIs and can drift from what Electron/main actually runs even after typecheck is green. apps/ade-cliandapps/webstill pin@types/node@^20.11.30; only desktop moves to 25 here.- No application source files change in this PR; the failure is entirely from the types package + existing sqlite usage.
Sent by Cursor Automation: BUGBOT in Versic
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/apps/desktop/types/node-25.9.1
branch
4 times, most recently
from
f35d71d to
33c16e4
Compare
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.19.37 to 25.9.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.9.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/apps/desktop/types/node-25.9.1
branch
from
33c16e4 to
4c660f1
Compare
Bumps @types/node from 20.19.37 to 25.9.1.
Commits