Fix using docker specific ignore with read-only build context#1349
Open
JaewonHur wants to merge 3 commits intoapple:mainfrom
Open
Fix using docker specific ignore with read-only build context#1349JaewonHur wants to merge 3 commits intoapple:mainfrom
JaewonHur wants to merge 3 commits intoapple:mainfrom
Conversation
saehejkang
reviewed
Apr 16, 2026
|
|
||
| extension Application { | ||
| public struct BuildCommand: AsyncLoggableCommand { | ||
| private static let hiddenDockerDir = ".com.apple.container.dockerfiles" |
Contributor
There was a problem hiding this comment.
This can be removed, as it is no longer being used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1343.
This PR depends on apple/container-builder-shim#72.
Do not create staging directory under build context, but pass dockerignore file bytes to the container-builder-shim.
Type of Change
Motivation and Context
[Why is this change needed?]
Testing