Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b95eab104e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| on: | ||
| release: | ||
| types: [published] |
There was a problem hiding this comment.
Restrict publish trigger to non-prerelease releases
Using release.types: [published] will also fire for GitHub prereleases, so this workflow can run npm publish for prerelease tags. Because npm publish here does not set a non-latest dist-tag, a prerelease run can unintentionally promote prerelease packages to normal consumers. Add a guard (for example, checking github.event.release.prerelease == false) or explicit prerelease tagging logic.
Useful? React with 👍 / 👎.
| - name: publish appdmg package | ||
| run: npm publish "$TARBALL" --provenance --access public |
There was a problem hiding this comment.
Make package publish steps rerun-safe
The workflow publishes @appdmg/appdmg and then @appdmg/cli in one linear job without checking whether a version is already on npm. If the first publish succeeds but the second fails (for example due to a transient npm outage), rerunning this workflow for the same release will fail on the first npm publish with “version already exists,” blocking recovery for the CLI package without creating a new release/version.
Useful? React with 👍 / 👎.
Summary
Verification