Skip to content

Add macOS DMG integration tests#14

Merged
jozefizso merged 2 commits into
mainfrom
node24-macos-integration
Apr 30, 2026
Merged

Add macOS DMG integration tests#14
jozefizso merged 2 commits into
mainfrom
node24-macos-integration

Conversation

@jozefizso
Copy link
Copy Markdown
Member

Summary

Adds the macOS integration workflow for the Node 24 appdmg packages.

  • adds npm run test:integration for real DMG-generation tests
  • creates, mounts, inspects, and detaches generated DMGs on macOS
  • covers modern JSON, legacy JSON, custom names, explicit image format, mounted volume, app bundle, document file, /Applications symlink, background assets, .VolumeIcon.icns, and .DS_Store
  • keeps npm test as the fast unit suite
  • adds a dedicated macOS integration CI job after the appdmg and CLI unit jobs
  • hardens the hdiutil attach mount parser for volume names containing spaces
  • keeps screenshot/capture-window comparison out of the default test path

Verification

  • npm test
  • npm run test:integration
  • npm audit --audit-level=moderate
  • npm ls --omit=dev --all
  • npm pack --dry-run
  • node --check ... for library sources and tests
  • npm ci && npm test && npm audit --audit-level=moderate && npm ls --omit=dev --all && npm pack --dry-run && node --check ... in packages/cli
  • workflow YAML parse

Closes #8

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ae6da4b3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

async function detach (mountPath) {
await execFileAsync('hdiutil', ['detach', mountPath])
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retry hdiutil detach in integration cleanup

The integration helper does a single hdiutil detach attempt, but macOS often returns transient Resource busy (exit code 16) immediately after file reads; this repo’s production detach path already handles that with retries (lib/darwin/hdiutil.js). In CI, a transient busy mount will make these integration tests fail even when DMG generation is correct, so cleanup should mirror the retry/backoff behavior to avoid flaky failures.

Useful? React with 👍 / 👎.

@jozefizso jozefizso merged commit ec82598 into main Apr 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add macOS integration test workflow

1 participant