chore(deps): update dependency typescript to v6#3516
Merged
Conversation
renovate
Bot
force-pushed
the
renovate/typescript-6.x
branch
2 times, most recently
from
ef632a0 to
17255ee
Compare
renovate
Bot
force-pushed
the
renovate/typescript-6.x
branch
from
17255ee to
928b510
Compare
Member
|
@copilot fix the build |
…bility TypeScript 6 introduced two breaking changes that affect this project: 1. `baseUrl` is deprecated - add `ignoreDeprecations: "6.0"` to silence 2. `types` defaults to `[]` instead of auto-discovering @types/* packages - explicitly add `"types": ["node"]` to include @types/node Agent-Logs-Url: https://github.com/apify/crawlee/sessions/b6c6bd17-4a8b-4778-ba7a-a6494449d68c
Contributor
Fixed in e4bcfc6. TypeScript 6 introduced two breaking changes:
All 18 packages build successfully. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot i dont want to ignore deprecations, dude |
Remove `ignoreDeprecations: "6.0"` and `baseUrl` from tsconfig.build.json. Convert baseUrl-relative imports in memory-storage to proper relative imports. Keep `baseUrl` in tsconfig.json only (needed by tsx/IDE tooling with paths). Agent-Logs-Url: https://github.com/apify/crawlee/sessions/af68fc69-bf1f-463d-8054-52e712314cec
Contributor
Removed |
Member
@copilot this feels wrong to me, i doubt it will pass the build |
- Remove `baseUrl` from `tsconfig.json`, prefix paths with `./` for get-tsconfig compatibility - Remove `baseUrl` from `test/tsconfig.json` (inherited), prefix paths with `../` - Add `test/*` path mapping in `test/tsconfig.json` for test/shared/* imports - Fix import sort order in request-queue.ts to satisfy eslint Agent-Logs-Url: https://github.com/apify/crawlee/sessions/42b91a99-10c4-48ab-965f-9b89ccaf792f
Contributor
You were right — the previous approach was incomplete. Fixed in 7cf1462. Removed
|
Member
@copilot i dont like this, why dont you just rewrite to use relative paths so its not needed? |
Contributor
Rewrote all 21 test files to use relative paths ( |
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
B4nan
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baseUrlfrom all tsconfig files (tsconfig.build.json,tsconfig.json,test/tsconfig.json) and convertbaseUrl-relative imports inpackages/memory-storageto proper relative importspathsvalues with./(root tsconfig) and../(test tsconfig) so they resolve correctly withoutbaseUrltest/shared/*imports in 21 test files to use relative paths (../shared/...or../../shared/...) instead of path-mapped importsBuffertype by adding"types": ["node"]totsconfig.build.json(TS6 changedtypesdefault from auto-discover to[])tsc-check-testsand lint pass💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.