Skip to content

WW-5622 Optimize Hibernate proxy detection when Hibernate is absent #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukaszlenart wants to merge 1 commit into
base: release/struts-6-8-x
Choose a base branch
from
+14 −0

WW-5622 perf(core): cache Hibernate class presence to avoid repeated …

2eede24
Select commit
Loading
Failed to load commit list.
Open

WW-5622 Optimize Hibernate proxy detection when Hibernate is absent #1650

WW-5622 perf(core): cache Hibernate class presence to avoid repeated …
2eede24
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 4, 2026 in 3m 20s

Quality Gate failed

Failed conditions
25 Security Hotspots
43.3% Coverage on New Code (required ≥ 80%)
3.3% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 453 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/TagFileProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Strings and Boxed types should be compared using "equals()". 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsIVnrVvptaKBuZuF&open=AZ1YsIVnrVvptaKBuZuF&pullRequest=1650

Check warning on line 70 in core/src/test/java/com/opensymphony/xwork2/conversion/impl/NumberConverterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsHbJrVvptaKBuZR6&open=AZ1YsHbJrVvptaKBuZR6&pullRequest=1650

Check warning on line 156 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/servlet/JspServletWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Combine this catch with the one at line 154, which has the same body. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsIeIrVvptaKBuZyV&open=AZ1YsIeIrVvptaKBuZyV&pullRequest=1650

Check warning on line 781 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/runtime/JspRuntimeLibrary.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsIijrVvptaKBuZ1h&open=AZ1YsIijrVvptaKBuZ1h&pullRequest=1650

Check warning on line 538 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/Compiler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do something with the "boolean" value returned by "delete". 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsIEnrVvptaKBuZed&open=AZ1YsIEnrVvptaKBuZed&pullRequest=1650

Check warning on line 159 in plugins/embeddedjsp/src/main/java/org/apache/struts2/el/parser/ELParser.html

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this deprecated "VALIGN" attribute. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsItUrVvptaKBuZ94&open=AZ1YsItUrVvptaKBuZ94&pullRequest=1650

Check warning on line 319 in plugins/json/src/main/java/org/apache/struts2/json/DefaultJSONWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsKFlrVvptaKBuaax&open=AZ1YsKFlrVvptaKBuaax&pullRequest=1650

Check warning on line 115 in plugins/portlet/src/main/java/org/apache/struts2/portlet/result/PortletVelocityResult.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsJZ4rVvptaKBuaPw&open=AZ1YsJZ4rVvptaKBuaPw&pullRequest=1650

Check warning on line 34 in core/src/main/java/com/opensymphony/xwork2/conversion/ObjectTypeDeterminer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsEu5rVvptaKBuY1H&open=AZ1YsEu5rVvptaKBuY1H&pullRequest=1650

Check failure on line 152 in plugins/osgi/src/main/java/org/apache/struts2/osgi/host/FelixOsgiHost.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.osgi.framework.Constants" for "FRAMEWORK_STORAGE_CLEAN". 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsJ9MrVvptaKBuaY4&open=AZ1YsJ9MrVvptaKBuaY4&pullRequest=1650

Check failure on line 87 in core/src/main/java/com/opensymphony/xwork2/interceptor/ParameterRemoverInterceptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsEVxrVvptaKBuYsz&open=AZ1YsEVxrVvptaKBuYsz&pullRequest=1650

Check warning on line 105 in core/src/test/java/com/opensymphony/xwork2/conversion/impl/AnnotationXWorkConverterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ValueStack"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsHanrVvptaKBuZRU&open=AZ1YsHanrVvptaKBuZRU&pullRequest=1650

Check warning on line 323 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/xmlparser/UTF8Reader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsH9brVvptaKBuZbe&open=AZ1YsH9brVvptaKBuZbe&pullRequest=1650

Check warning on line 109 in core/src/test/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ActionContext"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsG6ZrVvptaKBuZDe&open=AZ1YsG6ZrVvptaKBuZDe&pullRequest=1650

Check warning on line 453 in plugins/json/src/main/java/org/apache/struts2/json/DefaultJSONWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsKFlrVvptaKBuaa1&open=AZ1YsKFlrVvptaKBuaa1&pullRequest=1650

Check warning on line 175 in plugins/portlet/src/main/java/org/apache/struts2/portlet/result/PortletVelocityResult.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ActionContext"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsJZ4rVvptaKBuaP6&open=AZ1YsJZ4rVvptaKBuaP6&pullRequest=1650

Check warning on line 58 in core/src/main/java/com/opensymphony/xwork2/conversion/TypeConverterHolder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsEvQrVvptaKBuY1K&open=AZ1YsEvQrVvptaKBuY1K&pullRequest=1650

Check warning on line 68 in core/src/test/java/com/opensymphony/xwork2/ActionContextTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ActionContext"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsHlxrVvptaKBuZXE&open=AZ1YsHlxrVvptaKBuZXE&pullRequest=1650

Check warning on line 282 in plugins/oval/src/test/java/org/apache/struts2/oval/interceptor/OValValidationInterceptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ValidationAware"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsJ4krVvptaKBuaXM&open=AZ1YsJ4krVvptaKBuaXM&pullRequest=1650

Check warning on line 360 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/servlet/JspCServletContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsIdlrVvptaKBuZyC&open=AZ1YsIdlrVvptaKBuZyC&pullRequest=1650

Check warning on line 57 in core/src/main/java/com/opensymphony/xwork2/inject/util/FinalizableReferenceQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsDolrVvptaKBuYhe&open=AZ1YsDolrVvptaKBuYhe&pullRequest=1650

Check warning on line 633 in core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsHf-rVvptaKBuZUZ&open=AZ1YsHf-rVvptaKBuZUZ&pullRequest=1650

Check failure on line 323 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/Generator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsILFrVvptaKBuZkN&open=AZ1YsILFrVvptaKBuZkN&pullRequest=1650

Check warning on line 1814 in plugins/embeddedjsp/src/main/java/org/apache/struts2/el/parser/ELParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsI32rVvptaKBuaG8&open=AZ1YsI32rVvptaKBuaG8&pullRequest=1650

Check warning on line 58 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/el/ELContextImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the type specification in this constructor call with the diamond operator ("<>"). 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZ1YsIDSrVvptaKBuZd_&open=AZ1YsIDSrVvptaKBuZd_&pullRequest=1650
View more details on SonarQubeCloud