SOLR-17715: Remove "qt" param path support in SolrJ#4397
Open
r4mercur wants to merge 11 commits intoapache:mainfrom
Open
SOLR-17715: Remove "qt" param path support in SolrJ#4397r4mercur wants to merge 11 commits intoapache:mainfrom
r4mercur wants to merge 11 commits intoapache:mainfrom
Conversation
…7715-r4mercur # Conflicts: # solr/solrj/src/test/org/apache/solr/client/solrj/util/ClientUtilsTest.java
dsmiley
approved these changes
May 6, 2026
Contributor
dsmiley
left a comment
There was a problem hiding this comment.
Looks good; thanks!
I was gonna mention deprecating the other constructors but no... they are fine. After all, it's common to rely on a /select default.
I do think the no-arg constructor is weird/useless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17715
Related pull requests before: #3441
For transparency i used claude code and github copilot for recommendations.
Description
Please provide a short description of the changes you're making with this pull request.
Solution
Proposed solution changes in QueryRequest.java file.
Tests
Test cases which are added:
in class QueryRequestTest.java
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.