Introduce error propagation via OpChainConverter to streamline stage failure handling#18026
Merged
gortiz merged 1 commit intoapache:masterfrom Apr 1, 2026
Merged
Conversation
…e failure handling.
b31a144 to
7f95c28
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18026 +/- ##
============================================
+ Coverage 63.30% 63.32% +0.02%
Complexity 1543 1543
============================================
Files 3200 3200
Lines 194169 194167 -2
Branches 29915 29915
============================================
+ Hits 122914 122955 +41
+ Misses 61610 61567 -43
Partials 9645 9645
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
Mar 31, 2026
Contributor
xiangfu0
left a comment
There was a problem hiding this comment.
Auto-approved: LOW risk change (4 files, +107 net lines), bug fix for SPI error propagation, all 16 CI checks passed, comprehensive test coverage added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #17974, we introduced an SPI to convert opchains, but we missed the ability to use that SPI when an error is detected on pipeline breakers. This PR fixes that issue