Fix incorrect parameter names in GradientFormatter error messages#15781
Open
vinaykpud wants to merge 3 commits intoapache:mainfrom
Open
Fix incorrect parameter names in GradientFormatter error messages#15781vinaykpud wants to merge 3 commits intoapache:mainfrom
vinaykpud wants to merge 3 commits intoapache:mainfrom
Conversation
- Fix error message for maxForegroundColor validation that incorrectly referenced "minForegroundColor" - Fix error message for maxBackgroundColor validation that incorrectly referenced "minBackgroundColor" - Remove commented-out dead code (corpusReader, totalNumDocs) - Remove redundant duplicate zero-check in highlightTerm()
gaobinlong
approved these changes
Mar 4, 2026
|
|
||
| * GITHUB#15781: Fix incorrect parameter names in GradientFormatter error messages. Validation of | ||
| maxForegroundColor and maxBackgroundColor incorrectly referenced "minForegroundColor" and | ||
| "minBackgroundColor" in their error messages. Also removed dead code and a redundant |
Contributor
There was a problem hiding this comment.
Could we have a more concise change log? May generate it by LLM.
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description