Open
Conversation
SgtOmer
force-pushed
the
sgtomer/support_unplanned_logger_methods
branch
3 times, most recently
from
5075442 to
6870b83
Compare
SgtOmer
force-pushed
the
sgtomer/support_unplanned_logger_methods
branch
from
6870b83 to
e924f9b
Compare
Author
|
Sorry for the mess with all the force pushes, had a problem with the signing and the git name |
ppkarwasz
approved these changes
Apr 18, 2026
Contributor
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
Hi @SgtOmer,
Sorry for the late review.
My initial idea was to fail, whenever there is a new method we didn't take into consideration, but you are probably right: if an unsupported method from the Log4j API is called, we can just pass it through.
github-project-automation
bot
moved this from In review
to Approved
in Log4j pull request tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#220 - implemented the fix suggested