KNOX-3317: Fixed NPE when no token-metadata-headers are declared for ICEBERG-REST#1225
Merged
smolnar82 merged 1 commit intoapache:masterfrom May 8, 2026
Merged
KNOX-3317: Fixed NPE when no token-metadata-headers are declared for ICEBERG-REST#1225smolnar82 merged 1 commit intoapache:masterfrom
smolnar82 merged 1 commit intoapache:masterfrom
Conversation
Test Results21 tests 21 ✅ 1s ⏱️ Results for commit 49bd998. |
hanicz
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3317 - Add unit tests for TokenMetadataHeaderHandler
What changes were proposed in this pull request?
This PR introduces comprehensive unit tests for the
TokenMetadataHeaderHandlerclass within thegateway-service-restcatalogmodule.Specifically, it adds tests to:
NullPointerExceptionoccurs when thetoken-metadata-headersconfiguration parameter is missing (null).How was this patch tested?
The patch was tested by running the newly created unit tests and existing tests in the
gateway-service-restcatalogmodule:mvn -pl gateway-service-restcatalog testThe test suite
TokenMetadataHeaderHandlerTestincludes:testNullTokenMetadataHeadersConfig: Verifies the fix for the NPE.testEmptyTokenMetadataHeadersConfig: Verifies handling of empty configuration strings.testApplyHeaders: Verifies correct mapping of multiple metadata items to headers.testApplyHeadersCustomPrefix: Verifies that custom header prefixes are respected.testApplyHeadersMissingMetadata: Verifies that headers are not added if metadata is missing.Integration Tests
N/A
UI changes
(None)