KNOX-3258: Fix OIDC client login#1224
Open
bonampak wants to merge 3 commits intoapache:v2.1.xfrom
Open
Conversation
…j oidc client login.
…3) and use keycloak 21.1.2.
smolnar82
approved these changes
May 8, 2026
Contributor
smolnar82
left a comment
smolnar82
left a comment
There was a problem hiding this comment.
The changes looks good to me, thank you for your contribution.
Since this is for 2.1.x, I assume you plan to do some sort of testing in 3.0.0 too?
If so, please update the Docker-based tests with a Pac4j suite, where the integration tests you added here are much easier to maintain with our docker compose approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3258 - Fix OIDC client login
What changes were proposed in this pull request?
Updating oauth2-oidc-sdk to 9.13 to fix nimbus-jose-jwt:10.0.2 and pac4j-oidc:4.5.6 incompatibility
Adding integration test with testcontainers keycloak.
How was this patch tested?
Manual test and integration test.
Integration Tests
See Pac4jProviderOidcClientTest.
Before the library upgrade, the test fails with expected exception: java.lang.NoSuchMethodError: com.nimbusds.jwt.JWTClaimsSet.toJSONObject()Lnet/minidev/json/JSONObject
After the library upgrade, the test succeeds.