chore(ci): omit blanket/auto-trait/auto-derived impls from public API#2542
Open
xanderbailey wants to merge 1 commit into
Open
chore(ci): omit blanket/auto-trait/auto-derived impls from public API#2542xanderbailey wants to merge 1 commit into
xanderbailey wants to merge 1 commit into
Conversation
… output Pass -sss to cargo-public-api to reduce noise in public-api.txt files. This removes ~13k lines of auto-generated blanket impls, auto-trait impls, and auto-derived impls that obscure actual API surface changes in diffs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2525 introduced public-api files but after writing https://github.com/apache/iceberg-rust/pull/2541/changes I realised this might be a little too noisy since it incudes all auto-trait like
SendSyncetc.Options are:
I think -sss is enough for reviewers to be made aware of public API changes without it being so noisy that we don't pay attention to the actual changes. Downside is it's less "accurate" in the sense that a PR might introduce a change to the public API that wouldn't be caught in these tests so there's some sort of balance we need to strike here. Interested to know what the community thinks.
Which issue does this PR close?
What changes are included in this PR?
Pass -sss to cargo-public-api to reduce noise in public-api.txt files. This removes ~13k lines of auto-generated blanket impls, auto-trait impls, and auto-derived impls that obscure actual API surface changes in diffs.
Are these changes tested?