chore(refactor): add manifest list reader#2541
Open
xanderbailey wants to merge 3 commits into
Open
Conversation
xanderbailey
commented
May 30, 2026
| } | ||
|
|
||
| /// Load manifest list. | ||
| #[deprecated(since = "0.9.0", note = "Use `Table::manifest_list_reader()` instead")] |
Contributor
Author
There was a problem hiding this comment.
Wasn't actually sure if we wanted to deprecate or remove this? Also wasn't sure what version is correct here? I guess it should be deprecated from the next release? 0.10.0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Refactor required for PR which adds a
ManifestListReaderwhich mirrors the currentManifestListWriter. This will allow us to carry the encryption manager here also in the linked PRWhat changes are included in this PR?
Adds a new public struct
ManifestListReaderwhich carries the things required to read a manifest list. Refactors call-sites to use this new struct and adds a deprecation for the old method.Are these changes tested?