Fix ORCA permission checking crash for ROLLUP + window function queries#1643
Draft
lss602726449 wants to merge 1 commit intoapache:cbdb-postgres-mergefrom
Draft
Fix ORCA permission checking crash for ROLLUP + window function queries#1643lss602726449 wants to merge 1 commit intoapache:cbdb-postgres-mergefrom
lss602726449 wants to merge 1 commit intoapache:cbdb-postgres-mergefrom
Conversation
1. orca.c: transformGroupedWindows() incorrectly created an RTEPermissionInfo with relid=0 for a subquery RTE. Per PG16 commit a61b1f7, only RTE_RELATION entries need RTEPermissionInfo. This caused Assert(OidIsValid(perminfo->relid)) failure when ORCA translated ROLLUP + window function queries. 2. matview.c: replace_rte_with_delta() converted RTE_RELATION to RTE_SUBQUERY but forgot to clear perminfoindex, causing Assert(rte->rtekind == RTE_RELATION || ...) failure during IVM incremental maintenance with ORCA enabled. Also fix subquery not inheriting rteperminfos, and correct AddPerfmInfo/Perfission typos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lss602726449
force-pushed
the
fix_orca_perminfo
branch
from
d15ede4 to
4a21dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformGroupedWindows() incorrectly created an RTEPermissionInfo with relid=0 for a subquery RTE. Per PG16 commit a61b1f7, only RTE_RELATION entries need RTEPermissionInfo. This caused Assert(OidIsValid(perminfo->relid)) failure in ExecCheckPermissions when ORCA translated the query.
Also fix subquery not inheriting rteperminfos from the original query, and correct AddPerfmInfo/Perfission typos.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions