Fix SQLToolset read-only mode bypass via data-modifying CTEs and SELECT INTO#64173
Merged
eladkal merged 2 commits intoapache:mainfrom Mar 26, 2026
Merged
Fix SQLToolset read-only mode bypass via data-modifying CTEs and SELECT INTO#64173eladkal merged 2 commits intoapache:mainfrom
eladkal merged 2 commits intoapache:mainfrom
Conversation
kaxil
reviewed
Mar 24, 2026
gopidesupavan
approved these changes
Mar 25, 2026
kaxil
approved these changes
Mar 25, 2026
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Mar 30, 2026
…CT INTO (apache#64173) * Fix SQLToolset read-only mode bypass via data-modifying CTEs and SELECT INTO * fixes
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…CT INTO (apache#64173) * Fix SQLToolset read-only mode bypass via data-modifying CTEs and SELECT INTO * fixes
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…CT INTO (apache#64173) * Fix SQLToolset read-only mode bypass via data-modifying CTEs and SELECT INTO * fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not an expert for this provider but I think we should avoid DML statements.
The
validate_sqlfunction only checked the top-level statement type, so queries likeWITH d AS (DELETE FROM users RETURNING *) SELECT * FROM dorSELECT * INTO new_table FROM userspassed validation despite mutating data. This adds a deep AST scan that walks the full parse tree
and rejects any
INSERT,UPDATE,DELETE,MERGE,INTO, orCommandnodes found anywhereinside an otherwise-allowed SELECT. The scan only applies when using the default read-only allowlist;
callers who provide custom
allowed_typesare unaffected.Was generative AI tooling used to co-author this PR?
Claude Opus 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.