Revert "Optimize SecurityContext#isInOneOf (#1874)"#1875
Merged
cshannon merged 1 commit intoapache:mainfrom Apr 4, 2026
Merged
Revert "Optimize SecurityContext#isInOneOf (#1874)"#1875cshannon merged 1 commit intoapache:mainfrom
cshannon merged 1 commit intoapache:mainfrom
Conversation
This reverts commit b404e1e. This change needs more work because DefaultAuthorizationMap requires equals() to be used the way it handles a wildcard Principal. This needs to be fixed before the change can be made
mattrpav
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b404e1e.
This change needs more work because DefaultAuthorizationMap requires equals() to be used the way it handles a wildcard Principal. This needs to be fixed before the change can be made. We need to figure out a way to make contains() work or add some special handling for that map