Fix flaky XACompletionTest by adding wait for async states#1862
Merged
jbonofre merged 2 commits intoapache:mainfrom Apr 2, 2026
Conversation
jbonofre
previously approved these changes
Mar 30, 2026
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, I have just 2 suggestions for you.
activemq-unit-tests/src/test/java/org/apache/activemq/store/jdbc/XACompletionTest.java
Outdated
Show resolved
Hide resolved
gurpartap3697
force-pushed
the
fix/XACompletionTest-testStatsAndBrowseAfterAckPreparedRolledback-flaky-test
branch
from
e87d689 to
6c7cab0
Compare
Contributor
Author
|
Thanks @jbonofre for feedback! I updated the pr with suggested changes. |
jbonofre
approved these changes
Mar 31, 2026
Member
|
@gurpartap3697 good job ! I will merge as soon as CI is green. |
gurpartap3697
deleted the
fix/XACompletionTest-testStatsAndBrowseAfterAckPreparedRolledback-flaky-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XACompletionTest.testStatsAndBrowseAfterAckPreparedRolledback was failing intermittently:
ref: https://github.com/apache/activemq/actions/runs/23623154131/job/68806975829
The test relied on immediate JMX state, which is asynchronous and can lead to flakiness.