Fix: instant editor cloze bug#20656
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Apr 7, 2026
Merged
Conversation
Collaborator
|
Fixes #16936. |
8868988 to
f28624f
Compare
lukstbit
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Blocked by refactor: use field backing property in Instant Editor VM #20501When i was switching the increment or no increment, the no increment happens once but then again the cloze is incremented
setClozeFieldTextalways setcurrentClozeNumberto max + 1 regardless of the current cloze mode.There was bug if i tap the switch to increment button twice, and there are no clozes at all then it start with 2, i.e. -> Increment mode -> no increment mode -> increment mode, then starting cloze is 2
Fixes
Approach
Add fix and unit test to stop regression
How Has This Been Tested?
Pixel 10
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.