Skip to content

[Multiple-Profile]feat: add profile dialog#20654

Merged
mikehardy merged 2 commits intoankidroid:mainfrom
criticalAY:mp/add-profile-dialog
Apr 19, 2026
Merged

[Multiple-Profile]feat: add profile dialog#20654
mikehardy merged 2 commits intoankidroid:mainfrom
criticalAY:mp/add-profile-dialog

Conversation

@criticalAY
Copy link
Copy Markdown
Contributor

Purpose / Description

Add the dialog in multi profile fragment allowing to add profile, basically dialog implementation

Fixes

Approach

NA

How Has This Been Tested?

Pixel 10:
image

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY changed the title feat: add profile dialog [Multiple-Profile]feat: add profile dialog Apr 5, 2026
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementer's choice

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Apr 5, 2026
@criticalAY criticalAY force-pushed the mp/add-profile-dialog branch from 4abb206 to a2b07ec Compare April 5, 2026 17:46
@ZornHadNoChoice
Copy link
Copy Markdown
Collaborator

I suggest using the "Name" string used in similar dialogs.

@david-allison david-allison force-pushed the mp/add-profile-dialog branch from a2b07ec to 3e0099a Compare April 19, 2026 19:10
@david-allison david-allison force-pushed the mp/add-profile-dialog branch from 3e0099a to 6ed9f31 Compare April 19, 2026 19:12
Copy link
Copy Markdown
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged that Dialog PR from David today and since India timezones should be sleeping now :-), and David was up while I was working entire queue, I asked him to patch in the new validator stuff. He did and now it's squeaky-clean. Queueing for merge

@mikehardy mikehardy enabled auto-merge April 19, 2026 19:33
@mikehardy mikehardy added this pull request to the merge queue Apr 19, 2026
Merged via the queue into ankidroid:main with commit 58a6c1f Apr 19, 2026
15 checks passed
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Apr 19, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants