Improve instant note saving error dialog

[bartonlu]

Purpose / Description

Previously, the "Try Again" button was on the left, and the "Cancel" button was on the right. As well, clicking "Try Again" did not actually automatically reattempt to save the card.

Fixes

• Fixes Improve instant note save-failure dialog to align with Material guidelines #20638

Approach

This change swaps the order of the buttons and also triggers another save after clicking "Try Again"

How Has This Been Tested?

1. Add some code to trigger the savingErrorDialog each time there is an attempt to save an instant note

I added the following code:

// a flag
private var forceSaveFailureDialogForUiTest = true

// under handleSaveNoteResult()
if (forceSaveFailureDialogForUiTest) {
        // toggle the flag to false so you can test Try Again's new behaviour
        forceSaveFailureDialogForUiTest = false
        savingErrorDialog("Forced failure dialog for UI testing")
        return
    }

2. Attempt to save an Instant Note
3. Observe that 'Try Again' is on the right side, and 'Cancel' is on the left side.
4. Observe that clicking "Try Again" tries saving the card again immediately, rather than exiting out of the dialog back to the "Add" [dialog.]

savingErrorDialog.fixed.mp4

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[Ayush-Patel-56]

Hi @bartonlu use semantic commits in your PR, it's been easy to review it better. Thanks!

[criticalAY]

Looks good to me! thankyou

[criticalAY]

@bartonlu Please change the commit message to something meaningful

[bartonlu]

@Ayush-Patel-56 @criticalAY Thanks for the comments, I've changed the description of my commit! Let me know if you'd prefer a simple one-liner for this kind of change, or if explaining the reasoning for the change in the commit body is okay!

[Ayush-Patel-56]

Looks better now, thanks!