refactor: change pref key for analytics dialog#20585
Open
criticalAY wants to merge 5 commits intoankidroid:mainfrom
Open
refactor: change pref key for analytics dialog#20585criticalAY wants to merge 5 commits intoankidroid:mainfrom
criticalAY wants to merge 5 commits intoankidroid:mainfrom
Conversation
- refactor: update usage for analytics with new analytics
- analytics: set unchecked state as default
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Change the pref key for dialog to reset it for all users
Set the state to unchecked by default
Fixes
NA
Approach
NA
How Has This Been Tested?
I don't think we need test here since its pref key change and the dialog state is set to false
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.