Fix WSL install script: use wsl -e /bin/bash to avoid /bin/sh PATH issues#9
Merged
Merged
Conversation
The default WSL distro may be docker-desktop, which is a minimal environment without bash or curl. The install script now: - Enumerates WSL distros and filters out docker-desktop - Prompts the user to choose when multiple distros are available - Passes -d <distro> to all wsl invocations - Strips UTF-16 null bytes from wsl -l -q output - Updates devcontainer CLI link to install script page
aniongithub
force-pushed
the
aniongithub/fix-wsl-install-script
branch
from
8547523 to
537fbe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wsl bash -croutes through/bin/sh, which may not havebashin its PATH on minimal WSL distros. This causes the install to fail with:Fix: use
wsl -e /bin/bashto invoke bash directly, bypassing the default shell. Applied to all three WSL invocations in the script.