refactor(aria/tabs): clean up tab selection and linking to panels#32859
Merged
adolgachev merged 1 commit intoangular:mainfrom Apr 24, 2026
Merged
refactor(aria/tabs): clean up tab selection and linking to panels#32859adolgachev merged 1 commit intoangular:mainfrom
adolgachev merged 1 commit intoangular:mainfrom
Conversation
adolgachev
changed the title
adolgachev
added
Accessibility
|
Deployed dev-app for c5161de to: https://ng-dev-previews-comp--pr-angular-components-32859-dev-pxtvzh2b.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed docs-preview for 33fb4f4 to: https://ng-dev-previews-comp--pr-angular-components-32859-docs-58cy5tjn.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
aria-tabs
branch
6 times, most recently
from
9f18364 to
cb3c051
Compare
adolgachev
changed the title
adolgachev
force-pushed
the
aria-tabs
branch
7 times, most recently
from
f6c32a1 to
d913ebb
Compare
adolgachev
added
action: review
adolgachev
added
the
target: patch
adolgachev
force-pushed
the
aria-tabs
branch
2 times, most recently
from
c687368 to
b914539
Compare
Member
|
We should put this change on hold for two main reasons
|
adolgachev
force-pushed
the
aria-tabs
branch
2 times, most recently
from
374f2c5 to
2de91db
Compare
adolgachev
added
target: major
adolgachev
changed the title
ok7sai
reviewed
Apr 21, 2026
adolgachev
force-pushed
the
aria-tabs
branch
4 times, most recently
from
91dce82 to
d0613b3
Compare
ok7sai
approved these changes
Apr 24, 2026
adolgachev
added
action: merge
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors Tabs pattern to simplify how tabs are associated with their tab panels, as well as other dependent code.
This is a revision of the previous approach which swapped to use contentChildren and template references only
This just includes clean up and re-factoring to move the value matching of Tab and TabPanel to the directive and remove extra synching of selection and linked state in favor of a more direct approach.