test: use eager change detection in fake-async test component#32851
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 26, 2026
Merged
test: use eager change detection in fake-async test component#32851alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
The `AppComponent` template used within the `fake-async_spec.ts` files is updated to use `ChangeDetectionStrategy.Eager`. This ensures that change detection is triggered immediately as expected for these specific behavior tests.
alan-agius4
added
target: minor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the app.component.ts file used in Karma builder tests for fakeAsync behavior. It adds ChangeDetectionStrategy.Eager to the component's decorator, which helps ensure consistent and predictable change detection within the test environment. I have no feedback to provide.
dgp1130
approved these changes
Mar 26, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AppComponenttemplate used within thefake-async_spec.tsfiles is updated to useChangeDetectionStrategy.Eager. This ensures that change detection is triggered immediately as expected for these specific behavior tests.