fix(@angular/cli): restore console methods after logger completes

[oBusk]

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

console.log() when called after finally will be dropped. This could become an issue if code prints late like eslint which uses process.on("exit") to print timing information. This code will run after the logger has completed and will be dropped.

This means that TIMING=all ng lint does not work, eventhough eslint is seeing the var and collecting the data, but fails to print because console.log() is dead.

What is the new behavior?

Once the logger is completed, we reinsert console.log, console.info, console.warn and console.error so that any console logs that happens to trigger as the process is exiting, will still be printed to stdout.

Maybe there's a way to keep the logger living for longer, but since it's doing asyncronous things, I don't think we can clean it up in process.on('exit') or similiar? This fix at least prints to stdout as a best effort.

Does this PR introduce a breaking change?

• Yes
• No

Other information

Ran into this issue by trying to print the timing information when using ng lint (angular-eslint), and realised that they werent doing anything weird, the console log was running, it was just disapparing. After some more tracking I realised that angular-cli was the one hijacking console.log(), so hoping to clean out this little tripwire.

[gemini-code-assist]

Code Review

This pull request introduces the restoration of original console methods (log, info, warn, error) in the finally block to ensure consistent output from late consumers. The review suggests an improvement to make this restoration more robust and explicit by storing all original console methods in a single object to avoid assumptions and potential issues with chained assignments during restoration.

[alan-agius4]

LGTM, thanks

[clydin]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 4bbd1bf
• 21.2.x: a7787d0