arm/arm64: dts: adi: sc59x: fix I2C and CRC nodes by jiez · Pull Request #3209 · analogdevicesinc/linux

jiez · 2026-03-25T21:36:03Z

This patch does the following:

sc594-som.dtsi and sc598-som.dtsi: remove useless code
sc59x.dtsi: add i2c3/4/5 nodes; fix register block length in i2c controller nodes; fix register block base address, register block length, interrupt number in crc0 and crc1 nodes; add crc2 and crc3.
sc59x-64.dtsi: fix register block length for crc0 and crc1; add crc2 and crc3; add crc2_dma and crc3_dma in crc_cluster.

PR Description

Please replace this comment with a summary of your changes, and add any context
necessary to understand them. List any dependencies required for this change.
To check the checkboxes below, insert a 'x' between square brackets (without
any space), or simply check them after publishing the PR.
If you changes include a breaking change, please specify dependent PRs in the
description and try to push all related PRs simultaneously.

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have compiled my changes, including the documentation
I have tested the changes on the relevant hardware
I have updated the documentation outside this repo accordingly
I have provided links for the relevant upstream lore

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Only supports the ADZS-SC589-MINI Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>

Signed-off-by: UtsavAgarwalADI <utsav.agarwal@analog.com>

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com> Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com>

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Co-developed-by: Greg Malysa <greg.malysa@timesys.com> Signed-off-by: Greg Malysa <greg.malysa@timesys.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com>

Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com>

Adding SoC audio support for the following modes: - ASoC (linux only audio) - SHARC ALSA (Hybrid Audio) - SHARC Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>

Introduce a hidden Kconfig symbol COMMON_CLK_ADI_PLL to handle the shared PLL code in clk-adi-pll.c. Previously, the Makefile attempted to build clk-adi-pll.o based on architecture flags (ARCH_SC5XX, ARCH_SC59X_64), which is fragile and incorrect if multiple drivers are enabled or if they are built as modules. Update the specific clock drivers (SC57X, SC58X, SC594, SC598) to select COMMON_CLK_ADI_PLL, and update the Makefile to build clk-adi-pll.o only when this symbol is selected. Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Enable COMPILE_TEST for ADI system configuration and PADS drivers. This allows these drivers to be built on other architectures for testing purposes, increasing build coverage. Signed-off-by: Philip Molloy <philip.molloy@analog.com>

Remove the unused drivers/soc/adi/mach-sc59x/Kconfig file. The symbols defined in this file are not used. Fixes: ca0a7f7 ("soc: adi: Add initial support for SC5xx SoCs") Signed-off-by: Philip Molloy <philip.molloy@analog.com>

The `.legacy_dai_naming = 1` flag was inadvertently removed from the axi_spdif_component driver structure. Fixes: d23d7ee ("sound: soc: adi: Add ALSA support for ADSP-SC598") Signed-off-by: Philip Molloy <philip.molloy@analog.com>

The `.legacy_dai_naming = 1` flag was inadvertently removed from the axi_i2s_component driver structure. Fixes: d23d7ee ("sound: soc: adi: Add ALSA support for ADSP-SC598") Signed-off-by: Philip Molloy <philip.molloy@analog.com>

The output for the gige-reset line was not changed when the polarity of the gpio was changed, resulting in the gige-reset line being active all the time and preventing the probe of the ethernet. Fixes: 7eaf7e4 (ARM: dts: adi: fix polarity of GPIO signals) Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

Reconfiguring the partitions in the SPI and OSPI to remove the DTB partition and give the extra space to the rootfs partition. Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

GCC 15 changed the default C standard version to C23, which should not have impacted the kernel because it requests the gnu11 standard via '-std=' in the main Makefile. However, the x86 compressed boot Makefile uses its own set of KBUILD_CFLAGS without a '-std=' value (i.e., using the default), resulting in errors from the kernel's definitions of bool, true, and false in stddef.h, which are reserved keywords under C23. ./include/linux/stddef.h:11:9: error: expected identifier before ‘false’ 11 | false = 0, ./include/linux/types.h:35:33: error: two or more data types in declaration specifiers 35 | typedef _Bool bool; Set '-std=gnu11' in the x86 compressed boot Makefile to resolve the error and consistently use the same C standard version for the entire kernel. Closes: https://lore.kernel.org/4OAhbllK7x4QJGpZjkYjtBYNLd_2whHx9oFiuZcGwtVR4hIzvduultkgfAIRZI3vQpZylu7Gl929HaYFRGeMEalWCpeMzCIIhLxxRhq4U-Y=@protonmail.com/ Closes: https://lore.kernel.org/Z4467umXR2PZ0M1H@tucnak/ Reported-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com> Reported-by: Jakub Jelinek <jakub@redhat.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> Cc:stable@vger.kernel.org Link: https://lore.kernel.org/all/20250121-x86-use-std-consistently-gcc-15-v1-1-8ab0acf645cb%40kernel.org (cherry picked from commit ee2ab46) Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

Remove unused button-led device tree nodes from sc573-ezlite, and sc594-som boards. Signed-off-by: Ozan Durgut <ozndrgt@gmail.com>

Removing these hardcoded bootargs since they are not needed, bootargs are passed from U-boot for ADSP platforms. Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

Update the labels of SPI/OSPI partitions to maintain consistency across repos. Fixes: c400f44 (ARM: dts: adi: Update SPI and OSPI partitions in device tree) Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

pamolloy · 2026-03-26T07:26:35Z

 		can0 = &can0;
 		can1 = &can1;
 		rtc0 = &rtc0;
 */


Can you also look for other commented blocks like this and clean them up? 🙏

pamolloy · 2026-03-26T07:40:09Z

+			crypto_crc_poly = <0x5c5c5c5c>;
+			status = "disabled";
+		};
+


Please split the CRC changes into a separate commit. How did you come across the fact that the addresses were wrong and that there are two missing nodes? Is this the same in U-Boot? And where did you get the new interrupt numbers?

Because 0x31001200 is the base address of i2c5. So crc0 cannot have the same base address. When looking for the correct address in the manuals, I noticed that sc59x has 4 CRC devices while sc57x and sc58x have only 2. U-Boot does not have CRC devices in sc5xx devicetree files. All information are from the latest processor hardware reference manuals.

nunojsa

On top of Philip's comments, we should have one patch for ARM and another for arm64.

jiez · 2026-03-26T13:55:27Z

On top of Philip's comments, we should have one patch for ARM and another for arm64.

Why?

nunojsa · 2026-03-26T14:12:20Z

Basically because in linux we want self contained commits when possible. Like per arch, subystem, file... It likely does not apply/matter here but imagine you wanted to backport, apply this commit somewhere else only on ARM. You would need to take care about the arm64 changes.

jiez · 2026-03-26T14:20:26Z

Basically because in linux we want self contained commits when possible. Like per arch, subystem, file... It likely does not apply/matter here but imagine you wanted to backport, apply this commit somewhere else only on ARM. You would need to take care about the arm64 changes.

I don't see the possibility of this scenario. In what situation we will want to backport this change only on ARM but not ARM64?

nunojsa · 2026-03-26T14:51:53Z

I don't see the possibility of this scenario. In what situation we will want to backport this change only on ARM but not ARM64?

As I said, "...It likely does not apply/matter here...". But this is about processes and best practices. Up to you and Philip anyways 🤷‍♂️

This patch does the following: - sc594-som.dtsi: remove useless code - sc59x.dtsi: fix register block base address, register block length, interrupt number in crc0 and crc1 nodes; add crc2 and crc3. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

Fix register block length for crc0 and crc1. Add crc2 and crc3. Add crc2_dma and crc3_dma in crc_cluster. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

This patch does the following: - sc594-som.dtsi: remove useless code - sc59x.dtsi: add i2c3/4/5 nodes; fix register block length in i2c controller nodes. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

Remove useless code from sc598-som.dtsi. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

pamolloy · 2026-05-21T12:47:58Z

@jiez Please rebase this on top of adsp-6.18.31-y 🙏

pamolloy and others added 30 commits November 4, 2025 13:53

[ADI] .github: top-level: Initialize from adsp-6.12.38.y branch

0857545

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

arm64: Add ADI ADSP-SC598 SoC

bddf82f

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

clock: adi: Add PLL driver for ADSP-SC5xx

84f33f5

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

clock: Add driver for ADSP-SC5xx

71b82fe

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

soc: Add additional ADSP-SC5xxx SoC headers

5a009c1

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

dmaengine: Add support for ADSP-SC5xx DMA channels

4b12298

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

clocksource: Add support for ADSP-SC5xx generic timer

05d0959

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

spi: Add v3 SPI controller support for ADSP-SC5xx

a47e92c

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

gpio: Add GPIO port driver for ADSP-SC5xxx SoCs

2fe3021

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

i2c: Add TWI I2C support for ADSP-SC5xx

855ec98

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

serial: Add UART driver for SC5xx SoCs

eab94da

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

irqchip: Add PINT PORT driver for ADSP-SC5xx SoCs

85676fc

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

dt-bindings: clock: Add ADSP-SC5xx clock bindings

c8e1582

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

mtd: spi-nor: issi: Add support for is25lp512

56536c2

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

pinctrl: Add support for ADSP-SC5xx

0c90713

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

pinctrl: Add SRU control driver for ADSP-SC5xx

6d66ac9

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

ARM: Support 32-bit ADSP-SC5xx SoCs

265f31a

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

soc: adi: Add initial support for SC5xx SoCs

ca0a7f7

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

ARM: sc5xx: add ADSP-SC594 support

05b4975

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

ARM: sc5xx: add ADSP-SC58x support

2f91b87

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

ARM: sc5xx: add ADSP-SC573 support

970b60e

Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>

ARM: mach-sc5xx: Add init for 32-bit ADSP-SC5xx boards

4698f3f

Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>

clk: adi: Add clock driver for ADSP-SC594

9cf6b0c

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

clk: adi: Add clock driver for ADSP-SC589

b288b42

Only supports the ADZS-SC589-MINI Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>

clk: adi: Add clock driver for ADSP-SC573

df2ba6d

Signed-off-by: UtsavAgarwalADI <utsav.agarwal@analog.com>

net: stmmac: dwmac-adi: Add support for ADSP-SC598

2732646

Signed-off-by: Philip Molloy <philip.molloy@analog.com>

remoteproc: adi: Add driver for ADSP SHARC cores

e123eb0

Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com> Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com>

rpmsg: Add support for ADSP-SC598

b72f007

Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com>

sound: soc: adi: Add ALSA support for ADSP-SC598

d23d7ee

Adding SoC audio support for the following modes: - ASoC (linux only audio) - SHARC ALSA (Hybrid Audio) - SHARC Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>

pamolloy and others added 11 commits February 9, 2026 19:58

soc: adi: Support building with COMPILE_TEST

640be9e

Enable COMPILE_TEST for ADI system configuration and PADS drivers. This allows these drivers to be built on other architectures for testing purposes, increasing build coverage. Signed-off-by: Philip Molloy <philip.molloy@analog.com>

soc: adi: Remove unused mach-sc59x Kconfig

2bb3b45

Remove the unused drivers/soc/adi/mach-sc59x/Kconfig file. The symbols defined in this file are not used. Fixes: ca0a7f7 ("soc: adi: Add initial support for SC5xx SoCs") Signed-off-by: Philip Molloy <philip.molloy@analog.com>

ASoC: axi-spdif: Revert dropped legacy_dai_naming

30da689

The `.legacy_dai_naming = 1` flag was inadvertently removed from the axi_spdif_component driver structure. Fixes: d23d7ee ("sound: soc: adi: Add ALSA support for ADSP-SC598") Signed-off-by: Philip Molloy <philip.molloy@analog.com>

ASoC: axi-i2s: Restore removed legacy_dai_naming flag

0b82ac5

The `.legacy_dai_naming = 1` flag was inadvertently removed from the axi_i2s_component driver structure. Fixes: d23d7ee ("sound: soc: adi: Add ALSA support for ADSP-SC598") Signed-off-by: Philip Molloy <philip.molloy@analog.com>

ARM: dts: adi: Update SPI and OSPI partitions in device tree

c400f44

Reconfiguring the partitions in the SPI and OSPI to remove the DTB partition and give the extra space to the rootfs partition. Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

ARM: dts: adi: Remove dead adi,button-led nodes

a1e44fd

Remove unused button-led device tree nodes from sc573-ezlite, and sc594-som boards. Signed-off-by: Ozan Durgut <ozndrgt@gmail.com>

ARM: dts: adi: Remove hardcoded bootargs

a00d252

Removing these hardcoded bootargs since they are not needed, bootargs are passed from U-boot for ADSP platforms. Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

ARM: dts: adi: Update SPI and OSPI partition labels

750b80c

Update the labels of SPI/OSPI partitions to maintain consistency across repos. Fixes: c400f44 (ARM: dts: adi: Update SPI and OSPI partitions in device tree) Signed-off-by: Caleb Ethridge <caleb.ethridge@analog.com>

jiez requested review from a team, ozan956 and pamolloy March 25, 2026 21:36

jiez force-pushed the 3198-i2c-and-crc-nodes-missing-in-adsp-sc59x-devicetrees branch from 661c0b1 to 951725d Compare March 25, 2026 21:39

pamolloy added this to ADSP Mar 26, 2026

pamolloy reviewed Mar 26, 2026

View reviewed changes

nunojsa reviewed Mar 26, 2026

View reviewed changes

jiez added 4 commits March 26, 2026 14:59

arm: dts: adi: sc59x: fix CRC nodes

163a4fe

This patch does the following: - sc594-som.dtsi: remove useless code - sc59x.dtsi: fix register block base address, register block length, interrupt number in crc0 and crc1 nodes; add crc2 and crc3. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

arm64: dts: adi: fix CRC nodes for sc59x-64

8563629

Fix register block length for crc0 and crc1. Add crc2 and crc3. Add crc2_dma and crc3_dma in crc_cluster. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

arm: dts: adi: sc59x: fix I2C nodes

404c94d

This patch does the following: - sc594-som.dtsi: remove useless code - sc59x.dtsi: add i2c3/4/5 nodes; fix register block length in i2c controller nodes. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

arm64: dts: adi: remove useless code

f1c2c1d

Remove useless code from sc598-som.dtsi. Signed-off-by: Jie Zhang <jie.zhang@analog.com>

jiez force-pushed the 3198-i2c-and-crc-nodes-missing-in-adsp-sc59x-devicetrees branch from 951725d to f1c2c1d Compare March 26, 2026 21:32

pamolloy changed the base branch from adsp-6.12.0-y to adsp-6.18.31-y May 21, 2026 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

arm/arm64: dts: adi: sc59x: fix I2C and CRC nodes#3209

arm/arm64: dts: adi: sc59x: fix I2C and CRC nodes#3209
jiez wants to merge 100 commits into
adsp-6.18.31-yfrom
3198-i2c-and-crc-nodes-missing-in-adsp-sc59x-devicetrees

jiez commented Mar 25, 2026

Uh oh!

pamolloy Mar 26, 2026

Uh oh!

pamolloy Mar 26, 2026 •

edited

Loading

Uh oh!

jiez Mar 26, 2026

Uh oh!

nunojsa left a comment

Uh oh!

jiez commented Mar 26, 2026

Uh oh!

nunojsa commented Mar 26, 2026

Uh oh!

jiez commented Mar 26, 2026

Uh oh!

nunojsa commented Mar 26, 2026

Uh oh!

pamolloy commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

jiez commented Mar 25, 2026

PR Description

PR Type

PR Checklist

Uh oh!

pamolloy Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

pamolloy Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jiez Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

jiez commented Mar 26, 2026

Uh oh!

nunojsa commented Mar 26, 2026

Uh oh!

jiez commented Mar 26, 2026

Uh oh!

nunojsa commented Mar 26, 2026

Uh oh!

pamolloy commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pamolloy Mar 26, 2026 •

edited

Loading