Added ability to specify direction to the 'setAllowScrolling' method.#48
Open
sparkison wants to merge 2 commits intoalvarotrigo:masterfrom
Open
Added ability to specify direction to the 'setAllowScrolling' method.#48sparkison wants to merge 2 commits intoalvarotrigo:masterfrom
sparkison wants to merge 2 commits intoalvarotrigo:masterfrom
Conversation
added 2 commits
April 25, 2015 08:14
… Now takes arguments as in fullPage.js
Author
|
Set fixed. Confirmed working. |
Owner
|
Thanks for it! |
Owner
|
Could you commit it again after updating your copy? I can not merge it anymore. |
|
Where does this stand? This would be a handy feature for my site! |
Owner
|
@sethsacher it was never merged. I would encourage you to make use of fullPage.js instead, where this feature is implemented (and many others! ) I put much more time and effort on it and you can emulate the pagePiling.js behaviour by using the Parallax extension and using A related article about it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated code to take direction arguments for the setAllowScrolling method as in fullPage.js
Felt this was a missing, and a needed feature.