types: represent DTLS wire-code identifiers as compact newtypes#137
Open
zRedShift wants to merge 18 commits into
Open
types: represent DTLS wire-code identifiers as compact newtypes#137zRedShift wants to merge 18 commits into
zRedShift wants to merge 18 commits into
Conversation
7ba9b7e to
e8bec36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #134. This is a breaking API cleanup.
This converts DTLS/TLS wire-code identifier types from enums with
Unknown(...)variants into compact transparent integer newtypes. Known values remain exposed as associated constants, with the previous enum-style casing preserved to keep call-site churn down.Scope:
HashAlgorithm,SignatureAlgorithm,CompressionMethod,ContentType,NamedGroup,SignatureScheme,Dtls13CipherSuite, andProtocolVersionThe intent is to keep unknown wire values representable while avoiding enum padding/discriminants in parser and error payload paths. This does not intentionally change parser policy, replay behavior, queue behavior, or handshake semantics.
Validation:
git diff --check upstream/main..HEADcargo fmt --checkcheck-snowflake-local.pl upstream/maincargo test --all-targets --features rcgencargo clippy --all-targets --features rcgen -- -D warningscargo test --no-default-features --features rust-cryptocargo clippy --no-default-features --features rust-crypto -- -D warningscargo test --doc --features rcgen