Skip to content

Swallow transient packet parse errors#135

Merged
algesten merged 1 commit into
mainfrom
swallow-transient-packet-errors
May 29, 2026
Merged

Swallow transient packet parse errors#135
algesten merged 1 commit into
mainfrom
swallow-transient-packet-errors

Conversation

@algesten
Copy link
Copy Markdown
Owner

@algesten algesten commented May 28, 2026

Summary

  • hide transient packet parse errors from generated docs and move them to the end of Error
  • swallow ParseIncomplete, ParseError, and TooManyRecords from handle_packet
  • update edge/cookie tests to assert malformed datagrams are discarded

The idea here is that UDP packets could be mangled in route between client and server, or someone could spray garbage and/or intercepted packets at the server. Failed parsing is not a cause to throw out the connection.

This changes so all Error raised by dimpl publicly mean "throw away this connection"

@algesten algesten merged commit 1041429 into main May 29, 2026
46 checks passed
@algesten algesten deleted the swallow-transient-packet-errors branch May 29, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant