Add support for watcher annotations in the Files tab#248
Open
kroeschl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
I was looking at the the Files tab on a PR recently to see why I'd been added to the PR by our owners tooling, and didn't see any annotated files. The Duties tab showed that I'm a watch for one file, but it was annotated as expect. That's because the Owners-Watcher role didn't exist (I think) when owner, alternate, and reviewer/expert file annotations were added in this script.
Implementation
Using the implementation for expert/reviewer as an example, add watcher annotations.
Testing
Tested against the same PR, and I now see the annotation. Note that the annotation and expander overlap is an existing issue with all Files annotations that I'm not addressing in this PR.
Also verified that the notification content renders as expected.