Skip to content

AG-16865 Fix annotations toolbar to allow top level item buttons#6504

Merged
alantreadway merged 1 commit intolatestfrom
AG-16865-annotations-toolbar
Mar 25, 2026
Merged

AG-16865 Fix annotations toolbar to allow top level item buttons#6504
alantreadway merged 1 commit intolatestfrom
AG-16865-annotations-toolbar

Conversation

@lsjroberts
Copy link
Copy Markdown
Member

@lsjroberts lsjroberts marked this pull request as ready for review March 24, 2026 11:20
@github-actions
Copy link
Copy Markdown
Contributor

✅ Codex review complete; no issues found

View full review

AG-16865 Fix annotations toolbar to allow top level item buttons

PR: #6504
Author: lsjroberts | Base: latest ← Head: AG-16865-annotations-toolbar
Diff: 1 file changed, +66 -5

Summary

This PR extends the annotations toolbar to handle direct top-level annotation item buttons (for line, fibonacci, text, and shape items) instead of requiring menu wrappers. It introduces explicit switch cases and a shared helper to activate the pressed button and emit the create-annotation event.

Findings

P0: 0 | P1: 0 | P2: 0 | P3: 0

No issues found.

Verdict

Assessment: correct
Confidence: 0.91

The change is coherent and consistent with existing toolbar event flows: top-level item values are now explicitly handled and mapped to concrete annotation types without introducing obvious regressions in the shown code.

Required Actions: None - ready to merge

Copy link
Copy Markdown
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alantreadway alantreadway merged commit ed1b242 into latest Mar 25, 2026
41 checks passed
@alantreadway alantreadway deleted the AG-16865-annotations-toolbar branch March 25, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants