Skip to content

AG-14714 Fix ordinal initial zoom#6438

Draft
lsjroberts wants to merge 1 commit intolatestfrom
AG-14174-ordinal-initial-zoom
Draft

AG-14714 Fix ordinal initial zoom#6438
lsjroberts wants to merge 1 commit intolatestfrom
AG-14174-ordinal-initial-zoom

Conversation

@lsjroberts
Copy link
Copy Markdown
Member

@lsjroberts lsjroberts commented Mar 19, 2026

alantreadway
alantreadway approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsjroberts
AG-14714 Fix ordinal initial zoom
d6a71b5 
When an initialState.zoom.rangeX.end is provided and it is the
last value in an ordinal domain, the zoom.max is < 1. This fix
ensures it is unclampped and resolves to 1.
@lsjroberts lsjroberts force-pushed the AG-14174-ordinal-initial-zoom branch from 1542cb8 to d6a71b5 Compare March 19, 2026 12:29
@lsjroberts lsjroberts marked this pull request as ready for review March 19, 2026 12:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2026

✅ Codex review complete; no issues found

View full review

AG-14714 Fix ordinal initial zoom

PR: #6438
Author: lsjroberts | Base: latest ← Head: AG-14174-ordinal-initial-zoom
Diff: 1 file changed, +8 -1

Summary

This PR adjusts DiscreteTimeScale index selection for exclusive alignment at the upper bound. When the computed max index is the final band under exclusive alignment, it now returns undefined to allow clamping to scale end rather than forcing inclusion of the last index.

Findings

P0: 0 | P1: 0 | P2: 0 | P3: 0

No issues found.

Verdict

Assessment: correct
Confidence: 0.87

The change is tightly scoped and consistent with the stated intent for exclusive upper-bound behaviour, with no evident correctness regressions in the modified branch.

Required Actions: None - ready to merge

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2026

Snapshots automatically updated, please review before merge:

@lsjroberts lsjroberts marked this pull request as draft March 20, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alantreadway alantreadway alantreadway approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lsjroberts @alantreadway