Skip to content

CRT-1030, CRT-1044 Clear series-area highlight on legend item hover#6174

Open
olegat wants to merge 8 commits intolatestfrom
CRT-1030_CRT-1044/clear-seriesarea-highlight-on-legend-hover
Open

CRT-1030, CRT-1044 Clear series-area highlight on legend item hover#6174
olegat wants to merge 8 commits intolatestfrom
CRT-1030_CRT-1044/clear-seriesarea-highlight-on-legend-hover

Conversation

@olegat
Copy link
Contributor

@olegat olegat commented Feb 10, 2026

@olegat olegat marked this pull request as ready for review February 10, 2026 10:27
@olegat olegat requested a review from alantreadway as a code owner February 10, 2026 10:27
github-actions[bot]
github-actions bot reviewed Feb 10, 2026
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

❌ Codex review complete; 1 issue found (P0: 0 | P1: 1 | P2: 0 | P3: 0)

View full review

CRT-1030, CRT-1044 Clear series-area highlight on legend item hover

PR: #6174
Author: olegat | Base: b13.1.0 ← Head: CRT-1030_CRT-1044/clear-seriesarea-highlight-on-legend-hover
Diff: 3 files changed, +12 -1

Summary

Emits a legend hover event and clears series-area highlights when legend items are hovered to keep hover state in sync.

Findings

P0: 0 | P1: 1 | P2: 0 | P3: 0

1 inline comments posted.

Verdict

Assessment: incorrect
Confidence: 0.8

The change introduces a type import that does not exist, which breaks TypeScript compilation.

Required Actions:

  • Define LegendItemHoverEvent in eventsHub.ts or remove the import and adjust the handler to accept null/no argument.

@olegat olegat force-pushed the CRT-1030_CRT-1044/clear-seriesarea-highlight-on-legend-hover branch from b8de7f2 to 766d030 Compare February 10, 2026 10:45
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Snapshots automatically updated, please review before merge:

@olegat olegat force-pushed the CRT-1030_CRT-1044/clear-seriesarea-highlight-on-legend-hover branch from 766d030 to 82462ef Compare February 11, 2026 13:46
@olegat olegat requested a review from a team as a code owner February 11, 2026 13:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Snapshots automatically updated, please review before merge:

@olegat olegat force-pushed the CRT-1030_CRT-1044/clear-seriesarea-highlight-on-legend-hover branch from 82462ef to 147fec7 Compare March 24, 2026 10:09
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

Snapshots automatically updated, please review before merge:

olegat added 5 commits March 24, 2026 12:29
@olegat
AG-16741, AG-16744 Add popEvents() to line-example
1dcdf16
@olegat
CRT-1030, CRT-1044 Clear series-area highlight on legend item hover
d2d4b5b 
Conflicts:
	packages/ag-charts-community/src/chart/series/seriesAreaManager.ts
@olegat
CRT-1030, CRT-1044 Remove LegendItemHoverEvent
93db065 
I added this type locally in eventsHub.ts and then removed it, but forgot to
remove it from seriesAreaManager.ts
@olegat
AG-16741, AG-16744 Fix onLegendHover after rebase
3786fa9
@olegat
AG-16741 Add e2e test for legend keynav updating active
ab7e9e3
@olegat olegat force-pushed the CRT-1030_CRT-1044/clear-seriesarea-highlight-on-legend-hover branch from ba1d3f7 to ab7e9e3 Compare March 24, 2026 12:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

Snapshots automatically updated, please review before merge:

@olegat olegat changed the base branch from b13.1.0 to latest March 24, 2026 19:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

Snapshots automatically updated, please review before merge:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

Snapshots automatically updated, please review before merge:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@alantreadway alantreadway Awaiting requested review from alantreadway alantreadway is a code owner

@iMoses iMoses Awaiting requested review from iMoses

@rmc-software rmc-software Awaiting requested review from rmc-software

@markdurrant markdurrant Awaiting requested review from markdurrant

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@olegat