CRT-1033 Fix navigator.enabled & zoom.enabled toggling#6166
CRT-1033 Fix navigator.enabled & zoom.enabled toggling#6166alantreadway merged 5 commits intolatestfrom
Conversation
olegat
force-pushed
the
CRT-1033/fix_navigatorzoom_enabled_toggling
branch
from
0e46fe3 to
cb1dbc3
Compare
|
✅ Codex review complete; no issues found View full reviewCRT-1033 Fix navigator.enabled & zoom.enabled togglingPR: #6166 SummaryThis PR fixes zoom reset behaviour when toggling navigator/zoom by centralising reset logic in FindingsP0: 0 | P1: 0 | P2: 0 | P3: 0 No issues found. VerdictAssessment: correct The change cleanly removes conflicting reset paths and uses a single reset condition based on navigator/zoom/scrollbar enabled state, with no correctness regressions evident in the modified flow. Required Actions: None - ready to merge |
|
Snapshots automatically updated, please review before merge: |
The navigator.ts module does not need to call ZoomManager.updateZoom when navigator.enabled is `false`, the chart.ts will automatically reset the zoom if it detects that both navigator.enabled and zoom.enabled are `false`. Also, chart.ts was only resetting the X axis instead of the X and Y axis.
olegat
force-pushed
the
CRT-1033/fix_navigatorzoom_enabled_toggling
branch
from
cb1dbc3 to
aa96d3b
Compare
|
Snapshots automatically updated, please review before merge: |
The `height` variable is very used again after the initialisation of constant/readonly points.
…den again to zoom out"
…den again to zoom out"
2 participants
https://ag-grid.atlassian.net/browse/CRT-1033
The navigator.ts module does not need to call ZoomManager.updateZoom when navigator.enabled is
false, the chart.ts will automatically reset the zoom if it detects that both navigator.enabled and zoom.enabled arefalse.Also, chart.ts was only resetting the X axis instead of the X and Y axis.