Simplified and a bit more optimized solution#154
Open
FusionX9000 wants to merge 1 commit intoadnanaziz:masterfrom
Open
Simplified and a bit more optimized solution#154FusionX9000 wants to merge 1 commit intoadnanaziz:masterfrom
FusionX9000 wants to merge 1 commit intoadnanaziz:masterfrom
Conversation
Collaborator
|
Hi @FusionX9000 , Very good solution to simplify the code, and I am impressed. We will merge that in the future, and please be patient on this. |
tsunghsienlee
approved these changes
Jan 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using map's getOrDefault significantly reduces conditional checks required. I have also modified the solution a bit to only require a single pass. Further, since we're adding the results in a single pass, we don't care about swapping/changing indexes before the current index, which also halves hash table modifications required.
This is my first pull request, so I apologize in advance if I made a mistake.