Conversation
varyonic
force-pushed
the
propshaft
branch
11 times, most recently
from
ffdbcf0 to
109a92b
Compare
…and CSS with ActiveAdmin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to the asset pipeline support and JavaScript integration. Addition of Propshaft support alongside Sprockets, and a new JavaScript build process using Rollup.
Asset pipeline enhancements:
Added support for both Sprockets and Propshaft asset pipelines, including new gemfiles (
gemfiles/sprockets.gemfile,gemfiles/propshaft.gemfile) and updates to the CI workflow to test both variants. The Rails engine now auto-registers plugin assets for Propshaft.Updated Rails and DartSass configuration for compatibility with both asset pipelines, including a new DartSass initializer and conditional Sprockets configuration.
JavaScript and build process improvements:
package.jsonand Rollup configuration (rollup.config.mjs) for building bundled JavaScript and CSS assets, with SlimSelect as a dependencyGemfile and dependency management:
Gemfileto default to Sprockets for local development, with CI selecting the appropriate gemfile for each asset pipeline. Development/test dependencies are now specified per gemfile variant.