Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for Lua 5.1 function environments (fenv) by updating the evaluation scripts, variable handling, and the C++ backend's reference value system. Feedback suggests refactoring the environment detection logic in variables.lua to eliminate redundant assignments for the default global environment.
Comment on lines
+149
to
+161
| if LUAVERSION == 51 then | ||
| local fenv = rdebug.getfenv(info.func) | ||
| if fenv and not rdebug.equal(fenv, rdebug._G) then | ||
| eval = nil | ||
| value = fenv | ||
| else | ||
| eval = "_G" | ||
| value = rdebug._G | ||
| end | ||
| else | ||
| eval = "_G" | ||
| value = rdebug._G | ||
| end |
There was a problem hiding this comment.
The logic for setting the default global environment (_G) is duplicated in both the else branch of the Lua 5.1 check and the else branch of the custom environment check. This can be simplified by setting the defaults first and then overriding them only if the specific Lua 5.1 condition is met, which improves maintainability.
eval = "_G"
value = rdebug._G
if LUAVERSION == 51 then
local fenv = rdebug.getfenv(info.func)
if fenv and not rdebug.equal(fenv, rdebug._G) then
eval = nil
value = fenv
end
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically adds
setfenv/getfenvsupport for lua5.1/luajit