fix(upsert): use bounded file match filter to avoid scan planning segfault#11
Open
abnobdoss wants to merge 1 commit into
Open
fix(upsert): use bounded file match filter to avoid scan planning segfault#11abnobdoss wants to merge 1 commit into
abnobdoss wants to merge 1 commit into
Conversation
89dfcf6 to
3692011
Compare
3692011 to
bbfc654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a bounded file match filter for the initial upsert target scan. The exact match filter remains in place for overwrite and insert filtering.
Why
Composite-key upserts can build very large exact predicate trees before scanning target files. On affected runtimes that recursive predicate shape can overflow during scan planning. The bounded filter keeps initial scan predicate size tied to the number of join columns instead of the number of source keys.
Testing
139uv run python -m pytest tests/table/test_upsert.py -k "large_composite_key_initial_scan or file_match_filter or create_match_filter"uv run python -m pytest tests/table/test_upsert.py