refactor: migrate workspace from Nx to Turborepo + RStest + tsgo#384
Open
refactor: migrate workspace from Nx to Turborepo + RStest + tsgo#384
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the monorepo to remove Nx and migrate orchestration/build/test/lint tooling to Turborepo + tsgo + RStest + Oxlint/Oxfmt, while updating example apps/configs to run without Nx.
Changes:
- Removed Nx workspace artifacts/configs (
project.json, Jest preset/configs, Nx-specific example configs). - Added Turborepo/RStest/tsgo wiring (package scripts,
rstest.config.ts, normalizedtsconfig.jsonlayout). - Updated examples to use native Rspack/Webpack/Rollup configs and switched lint/format to Oxlint/Oxfmt.
Reviewed changes
Copilot reviewed 298 out of 542 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/zephyr-agent/src/lib/logging/file-logger.ts | Formatting-only refactor in logger utilities |
| libs/zephyr-agent/src/lib/logging/debug-enabled.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/logging/cli-format.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/http/upload-snapshot.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/http/upload-file.test.ts | Jest → RStest mocking migration adjustments |
| libs/zephyr-agent/src/lib/http/upload-envs.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/http/http-request.ts | Type refinement for fetch body + formatting |
| libs/zephyr-agent/src/lib/http/http-request.test.ts | Jest → RStest test/mocking migration |
| libs/zephyr-agent/src/lib/errors/zephyr-error.ts | Formatting-only import/layout changes |
| libs/zephyr-agent/src/lib/errors/handle-global-error.test.ts | Jest → RStest mocking migration |
| libs/zephyr-agent/src/lib/env-variables/index.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/edge-requests/get-application-configuration.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/edge-hash-list/get-cache-key.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/edge-actions/ze-upload-snapshot.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/edge-actions/ze-upload-build-stats.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/edge-actions/ze-upload-assets.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/edge-actions/ze-enable-snapshot-on-edge.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/edge-actions/generate-manifest-asset.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/deployment/get-upload-strategy.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/deployment/common-upload.strategy.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/deployment/aws-upload.strategy.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/build-context/ze-util-read-package-json.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/build-context/ze-util-parse-ze-dependencies.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/build-context/git-provider-utils.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/build-context/detect-monorepo.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/build-context/tests/ze-util-get-git-info-ci.test.ts | Jest → RStest mocking migration |
| libs/zephyr-agent/src/lib/build-context/test/ze-util-parse-ze-dependencies.test.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/build-context/test/git-provider-utils.test.ts | Formatting-only refactor |
| libs/zephyr-agent/src/lib/auth/login.test.ts | Jest → RStest mocking migration |
| libs/zephyr-agent/src/index.ts | Formatting-only export layout changes |
| libs/zephyr-agent/rstest.config.ts | Adds RStest config for package tests |
| libs/zephyr-agent/project.json | Removes Nx project configuration |
| libs/zephyr-agent/package.json | Switches scripts to tsgo/rstest/oxlint and adds publish metadata |
| libs/zephyr-agent/jest.config.ts | Removes Jest config |
| libs/zephyr-agent/eslint.config.mjs | Removes Nx-era ESLint config |
| libs/with-zephyr/tsconfig.spec.json | Switches spec types/includes to RStest |
| libs/with-zephyr/tsconfig.lib.json | Removes split lib tsconfig |
| libs/with-zephyr/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| libs/with-zephyr/src/tests/package-manager.test.ts | Formatting-only refactor |
| libs/with-zephyr/src/tests/bundler-configs.test.ts | Formatting-only refactor |
| libs/with-zephyr/src/slidev-vite.ts | Formatting-only refactor |
| libs/with-zephyr/src/package-manager.ts | Formatting-only refactor + env access tweak |
| libs/with-zephyr/src/nextjs-vinext.ts | Formatting-only refactor |
| libs/with-zephyr/src/engine/ast-grep.ts | Formatting-only refactor |
| libs/with-zephyr/src/bundlers/vite.ts | Formatting-only refactor |
| libs/with-zephyr/src/bundlers/nuxt.ts | Formatting-only refactor |
| libs/with-zephyr/src/bundlers/metro.ts | Formatting-only refactor |
| libs/with-zephyr/src/bundlers/astro.ts | Formatting-only refactor |
| libs/with-zephyr/project.json | Removes Nx project configuration |
| libs/with-zephyr/eslint.config.mjs | Removes Nx-era ESLint config |
| libs/with-zephyr/README.md | Updates docs/examples away from Nx commands |
| libs/vite-plugin-zephyr/tsconfig.spec.json | Switches spec types/includes to RStest |
| libs/vite-plugin-zephyr/tsconfig.lib.json | Removes split lib tsconfig |
| libs/vite-plugin-zephyr/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| libs/vite-plugin-zephyr/src/lib/vite-plugin-zephyr.spec.ts | Jest → RStest test migration + assertions updated |
| libs/vite-plugin-zephyr/src/lib/vite-plugin-zephyr-partial.ts | Formatting-only refactor |
| libs/vite-plugin-zephyr/src/lib/internal/mf-vite-etl/inject_resolved_remotes.ts | Formatting-only refactor |
| libs/vite-plugin-zephyr/src/lib/internal/mf-vite-etl/extract-mf-vite-remotes.ts | Formatting-only refactor |
| libs/vite-plugin-zephyr/src/lib/internal/extract/extract_vite_assets_map.ts | Formatting-only refactor |
| libs/vite-plugin-zephyr/src/lib/internal/extract/test/extract_vite_assets_map.test.ts | Jest → RStest mocking migration |
| libs/vite-plugin-zephyr/rstest.config.ts | Adds RStest config for package tests |
| libs/vite-plugin-zephyr/project.json | Removes Nx project configuration |
| libs/vite-plugin-zephyr/jest.config.ts | Removes Jest config |
| libs/vite-plugin-zephyr/eslint.config.mjs | Removes Nx-era ESLint config |
| libs/vite-plugin-zephyr/README.md | Formatting-only doc import layout |
| libs/vite-plugin-vinext-zephyr/tsconfig.spec.json | Switches spec types/includes to RStest |
| libs/vite-plugin-vinext-zephyr/tsconfig.lib.json | Removes split lib tsconfig |
| libs/vite-plugin-vinext-zephyr/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| libs/vite-plugin-vinext-zephyr/src/lib/vite-plugin-vinext-zephyr.ts | Formatting-only refactor |
| libs/vite-plugin-vinext-zephyr/src/lib/internal/vinext-output.ts | Formatting-only refactor |
| libs/vite-plugin-vinext-zephyr/rstest.config.ts | Adds RStest config for package tests |
| libs/vite-plugin-vinext-zephyr/project.json | Removes Nx project configuration |
| libs/vite-plugin-vinext-zephyr/jest.config.ts | Removes Jest config |
| libs/vite-plugin-vinext-zephyr/eslint.config.mjs | Removes Nx-era ESLint config |
| libs/vite-plugin-tanstack-start-zephyr/tsconfig.spec.json | Switches spec types/includes to RStest |
| libs/vite-plugin-tanstack-start-zephyr/tsconfig.lib.json | Removes split lib tsconfig |
| libs/vite-plugin-tanstack-start-zephyr/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| libs/vite-plugin-tanstack-start-zephyr/src/lib/vite-plugin-tanstack-start-zephyr.ts | Formatting-only refactor |
| libs/vite-plugin-tanstack-start-zephyr/src/lib/vite-plugin-tanstack-start-zephyr.spec.ts | Adds RStest mock to isolate zephyr-agent usage |
| libs/vite-plugin-tanstack-start-zephyr/src/lib/internal/extract/load-tanstack-output.ts | Formatting-only refactor |
| libs/vite-plugin-tanstack-start-zephyr/rstest.config.ts | Adds RStest config for package tests |
| libs/vite-plugin-tanstack-start-zephyr/project.json | Removes Nx project configuration |
| libs/vite-plugin-tanstack-start-zephyr/jest.config.ts | Removes Jest config |
| libs/vite-plugin-tanstack-start-zephyr/.eslintrc.json | Removes Nx-era ESLint config |
| libs/rollup-plugin-zephyr/tsconfig.spec.json | Switches spec types/includes to RStest |
| libs/rollup-plugin-zephyr/tsconfig.lib.json | Removes split lib tsconfig |
| libs/rollup-plugin-zephyr/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| libs/rollup-plugin-zephyr/src/lib/transform/get-assets-map.ts | Formatting-only refactor |
| libs/rollup-plugin-zephyr/src/lib/rollup-plugin-zephyr.ts | Formatting-only refactor |
| libs/rollup-plugin-zephyr/rstest.config.ts | Adds RStest config for package tests |
| libs/rollup-plugin-zephyr/project.json | Removes Nx project configuration |
| libs/rollup-plugin-zephyr/package.json | Switches scripts to tsgo/rstest/oxlint and adds publish metadata |
| libs/rollup-plugin-zephyr/jest.config.ts | Removes Jest config |
| libs/rollup-plugin-zephyr/eslint.config.mjs | Removes Nx-era ESLint config |
| libs/parcel-reporter-zephyr/tsconfig.spec.json | Switches spec types/includes to RStest |
| libs/parcel-reporter-zephyr/tsconfig.lib.json | Removes split lib tsconfig |
| libs/parcel-reporter-zephyr/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| libs/parcel-reporter-zephyr/src/lib/on-build-success.ts | Formatting-only refactor |
| libs/parcel-reporter-zephyr/src/lib/get-assets-map.ts | Formatting-only refactor |
| libs/parcel-reporter-zephyr/src/index.ts | Formatting-only refactor |
| libs/parcel-reporter-zephyr/rstest.config.ts | Adds RStest config for package tests |
| libs/parcel-reporter-zephyr/project.json | Removes Nx project configuration |
| libs/parcel-reporter-zephyr/package.json | Switches scripts to tsgo/rstest/oxlint and adds publish metadata |
| libs/parcel-reporter-zephyr/jest.config.ts | Removes Jest config |
| libs/parcel-reporter-zephyr/eslint.config.mjs | Removes Nx-era ESLint config |
| libs/create-zephyr-apps/tsconfig.spec.json | Switches spec types/includes to RStest |
| libs/create-zephyr-apps/tsconfig.lib.json | Removes split lib tsconfig |
| libs/create-zephyr-apps/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| libs/create-zephyr-apps/src/index.ts | Minor formatting change in cleanup promise |
| libs/create-zephyr-apps/rstest.config.ts | Adds RStest config for package tests |
| libs/create-zephyr-apps/project.json | Removes Nx project configuration |
| libs/create-zephyr-apps/package.json | Switches scripts to tsgo/rstest/oxlint and adds publish metadata |
| libs/create-zephyr-apps/jest.config.ts | Removes Jest config |
| libs/create-zephyr-apps/eslint.config.mjs | Removes Nx-era ESLint config |
| jest.preset.js | Removes Nx Jest preset |
| jest.config.ts | Removes Nx Jest project aggregator |
| examples/zephyr-cli-test/package.json | Switches lint/format from Biome to Oxlint/Oxfmt |
| examples/zephyr-cli-test/biome.json | Removes Biome config |
| examples/vite-react-ts/package.json | Switches build from tsc to tsgo and uses turbo prebuild |
| examples/vite-react-ts/eslint.config.mjs | Removes local ESLint config |
| examples/vite-react-mf/webpack/webpack.config.js | Formatting-only refactor |
| examples/vite-react-mf/webpack/package.json | Dependency ordering/organization updates |
| examples/vite-react-mf/rspack/rspack.config.js | Formatting-only refactor |
| examples/vite-react-mf/rspack/package.json | Adds missing runtime deps like tslib; reorganizes deps |
| examples/vite-react-mf/remote/vite.config.ts | Formatting-only refactor |
| examples/vite-react-mf/remote/package.json | Switches build/lint tooling (tsgo/oxlint) |
| examples/vite-react-mf/remote/eslint.config.js | Removes local ESLint config |
| examples/vite-react-mf/host/vite.config.ts | Formatting-only refactor |
| examples/vite-react-mf/host/package.json | Switches lint tooling (oxlint) |
| examples/vite-react-mf/host/eslint.config.js | Removes local ESLint config |
| examples/vinext-hackernews/package.json | Minor key reordering |
| examples/vinext-hackernews/lib/fetch-data.ts | Formatting-only refactor |
| examples/sample-webpack-application/webpack.config.ts | Removes Nx webpack config wrapper |
| examples/sample-webpack-application/webpack.config.cjs | Adds native webpack config without Nx |
| examples/sample-webpack-application/tsconfig.spec.json | Switches spec types/includes to RStest |
| examples/sample-webpack-application/tsconfig.json | Switches base tsconfig reference |
| examples/sample-webpack-application/tsconfig.app.json | Updates excludes for RStest config |
| examples/sample-webpack-application/src/app/welcome.tsx | Replaces NxWelcome with a minimal component |
| examples/sample-webpack-application/src/app/app.tsx | Removes NxWelcome usage; uses local Welcome component |
| examples/sample-webpack-application/src/app/app.spec.tsx | Updates assertion to new UI text |
| examples/sample-webpack-application/rstest.config.ts | Adds RStest config for example tests |
| examples/sample-webpack-application/project.json | Removes Nx project configuration |
| examples/sample-webpack-application/package.json | Switches start/build scripts to plain webpack |
| examples/sample-webpack-application/jest.config.ts | Removes Jest config |
| examples/sample-webpack-application/eslint.config.mjs | Removes Nx-era ESLint config |
| examples/sample-rspack-application/tsconfig.spec.json | Switches spec types/includes to RStest |
| examples/sample-rspack-application/tsconfig.json | Switches base tsconfig reference |
| examples/sample-rspack-application/tsconfig.app.json | Updates excludes for RStest config |
| examples/sample-rspack-application/src/app/welcome.tsx | Replaces NxWelcome with a minimal component |
| examples/sample-rspack-application/src/app/app.tsx | Removes NxWelcome usage; uses local Welcome component |
| examples/sample-rspack-application/src/app/app.spec.tsx | Updates assertion to new UI text |
| examples/sample-rspack-application/rstest.config.ts | Adds RStest config for example tests |
| examples/sample-rspack-application/rspack.config.js | Replaces Nx composePlugins config with native Rspack config |
| examples/sample-rspack-application/project.json | Removes Nx project configuration |
| examples/sample-rspack-application/package.json | Switches start/build scripts to rspack CLI |
| examples/sample-rspack-application/jest.config.ts | Removes Jest config |
| examples/rspress-v1/package.json | Minor dependency order cleanup |
| examples/rspack-nx-mf/package.json | Adds pnpm scripts for non-Nx build/serve orchestration |
| examples/rspack-nx-mf/apps/remote/tsconfig.spec.json | Switches spec types/includes to RStest |
| examples/rspack-nx-mf/apps/remote/tsconfig.json | Switches base tsconfig reference |
| examples/rspack-nx-mf/apps/remote/tsconfig.app.json | Updates excludes for RStest config |
| examples/rspack-nx-mf/apps/remote/src/app/remote-welcome.tsx | Replaces NxWelcome with a minimal component |
| examples/rspack-nx-mf/apps/remote/src/app/app.tsx | Uses new RemoteWelcome component |
| examples/rspack-nx-mf/apps/remote/src/app/app.spec.tsx | Updates assertion to new UI text |
| examples/rspack-nx-mf/apps/remote/rstest.config.ts | Adds RStest config for example tests |
| examples/rspack-nx-mf/apps/remote/rspack.config.ts | Removes Nx rspack config |
| examples/rspack-nx-mf/apps/remote/rspack.config.prod.ts | Removes Nx prod shim |
| examples/rspack-nx-mf/apps/remote/rspack.config.js | Adds native Rspack config with MF plugin |
| examples/rspack-nx-mf/apps/remote/project.json | Removes Nx project configuration |
| examples/rspack-nx-mf/apps/remote/package.json | Adds rspack/rstest/oxlint scripts and devDeps |
| examples/rspack-nx-mf/apps/remote/module-federation.config.ts | Removes Nx-typed MF config |
| examples/rspack-nx-mf/apps/remote/module-federation.config.js | Adds plain MF config for enhanced federation |
| examples/rspack-nx-mf/apps/remote/jest.config.ts | Removes Jest config |
| examples/rspack-nx-mf/apps/remote/.eslintrc.json | Removes Nx-era ESLint config |
| examples/rspack-nx-mf/apps/host/tsconfig.spec.json | Switches spec types/includes to RStest |
| examples/rspack-nx-mf/apps/host/tsconfig.json | Switches base tsconfig reference |
| examples/rspack-nx-mf/apps/host/tsconfig.app.json | Updates excludes for RStest config |
| examples/rspack-nx-mf/apps/host/src/app/host-welcome.tsx | Replaces NxWelcome with a minimal component |
| examples/rspack-nx-mf/apps/host/src/app/app.tsx | Uses HostWelcome and React lazy/Suspense imports |
| examples/rspack-nx-mf/apps/host/src/app/app.spec.tsx | Updates router + adds virtual remote mock |
| examples/rspack-nx-mf/apps/host/rstest.config.ts | Adds RStest config for example tests |
| examples/rspack-nx-mf/apps/host/rspack.config.ts | Removes Nx rspack config |
| examples/rspack-nx-mf/apps/host/rspack.config.prod.ts | Removes Nx prod config |
| examples/rspack-nx-mf/apps/host/rspack.config.js | Adds native Rspack config with MF plugin |
| examples/rspack-nx-mf/apps/host/project.json | Removes Nx project configuration |
| examples/rspack-nx-mf/apps/host/package.json | Adds rspack/rstest/oxlint scripts and devDeps |
| examples/rspack-nx-mf/apps/host/module-federation.config.ts | Removes Nx-typed MF config |
| examples/rspack-nx-mf/apps/host/module-federation.config.js | Adds plain MF config mapping remote URL |
| examples/rspack-nx-mf/apps/host/jest.config.ts | Removes Jest config |
| examples/rspack-nx-mf/apps/host/.eslintrc.json | Removes Nx-era ESLint config |
| examples/rspack-mf/package.json | Adds pnpm scripts for non-Nx build/serve orchestration |
| examples/rspack-mf/apps/remote/tsconfig.json | Switches base tsconfig reference |
| examples/rspack-mf/apps/remote/tsconfig.app.json | Updates excludes for RStest config |
| examples/rspack-mf/apps/remote/src/app/remote-welcome.tsx | Adds remote welcome component |
| examples/rspack-mf/apps/remote/src/app/app.tsx | Uses RemoteWelcome in app |
| examples/rspack-mf/apps/remote/rspack.config.js | Replaces Nx composePlugins config with native Rspack config |
| examples/rspack-mf/apps/remote/project.json | Removes Nx project configuration |
| examples/rspack-mf/apps/remote/package.json | Adds rspack scripts and devDeps |
| examples/rspack-mf/apps/remote/module-federation.config.js | Converts MF config to enhanced federation shared object form |
| examples/rspack-mf/apps/host/tsconfig.json | Switches base tsconfig reference |
| examples/rspack-mf/apps/host/tsconfig.app.json | Updates excludes for RStest config |
| examples/rspack-mf/apps/host/src/app/app.tsx | Updates remote import/usage names |
| examples/rspack-mf/apps/host/rspack.config.js | Replaces Nx composePlugins config with native Rspack config |
| examples/rspack-mf/apps/host/project.json | Removes Nx project configuration |
| examples/rspack-mf/apps/host/package.json | Adds rspack scripts and devDeps |
| examples/rspack-mf/apps/host/module-federation.config.js | Converts MF config to enhanced federation shared object form |
| examples/rspack-mf/README.md | Updates build/serve instructions to pnpm/turbo style |
| examples/rsbuild-sample-app/package.json | Minor key reordering |
| examples/rollup-sample-lib/tsconfig.lib.json | Removes Nx-era split tsconfig |
| examples/rollup-sample-lib/tsconfig.json | Normalizes tsconfig and excludes test/rstest config |
| examples/rollup-sample-lib/rollup.config.js | Replaces Nx wrapper config with explicit Rollup pipeline |
| examples/rollup-sample-lib/project.json | Removes Nx project configuration |
| examples/rollup-sample-lib/package.json | Switches build to raw rollup CLI and adds plugin deps |
| examples/rollup-sample-lib/eslint.config.mjs | Removes Nx-era ESLint config |
| examples/rollup-sample-lib/README.md | Updates docs away from Nx/Jest |
| examples/react-micro-frontends/package.json | Switches orchestration from Nx to pnpm filters; adds rspack deps |
| examples/react-micro-frontends/apps/team-red/tsconfig.spec.json | Switches spec types/includes to RStest |
| examples/react-micro-frontends/apps/team-red/tsconfig.json | Switches base tsconfig reference |
| examples/react-micro-frontends/apps/team-red/tsconfig.app.json | Updates excludes for RStest config |
| examples/react-micro-frontends/apps/team-red/rstest.config.ts | Adds RStest config for example tests |
| examples/react-micro-frontends/apps/team-red/project.json | Removes Nx project configuration |
| examples/react-micro-frontends/apps/team-red/package.json | Adds rspack/rstest/oxlint scripts and devDeps |
| examples/react-micro-frontends/apps/team-red/jest.config.ts | Removes Jest config |
| examples/react-micro-frontends/apps/team-red/eslint.config.mjs | Removes Nx-era ESLint config |
| examples/react-micro-frontends/apps/team-green/tsconfig.spec.json | Switches spec types/includes to RStest |
| examples/react-micro-frontends/apps/team-green/tsconfig.json | Switches base tsconfig reference |
| examples/react-micro-frontends/apps/team-green/tsconfig.app.json | Updates excludes for RStest config |
| examples/react-micro-frontends/apps/team-green/rstest.config.ts | Adds RStest config for example tests |
| examples/react-micro-frontends/apps/team-green/project.json | Removes Nx project configuration |
| examples/react-micro-frontends/apps/team-green/package.json | Adds rspack/rstest/oxlint scripts and devDeps |
| examples/react-micro-frontends/apps/team-green/jest.config.ts | Removes Jest config |
| examples/react-micro-frontends/apps/team-green/eslint.config.mjs | Removes Nx-era ESLint config |
| examples/react-micro-frontends/apps/team-blue/tsconfig.spec.json | Switches spec types/includes to RStest |
| examples/react-micro-frontends/apps/team-blue/tsconfig.json | Switches base tsconfig reference |
| examples/react-micro-frontends/apps/team-blue/tsconfig.app.json | Updates excludes for RStest config |
| examples/react-micro-frontends/apps/team-blue/rstest.config.ts | Adds RStest config for example tests |
| examples/react-micro-frontends/apps/team-blue/package.json | Adds scripts + tooling deps (rspack/rstest/oxlint) |
| examples/react-micro-frontends/apps/team-blue/jest.config.ts | Removes Jest config |
| examples/react-micro-frontends/apps/team-blue/eslint.config.mjs | Removes Nx-era ESLint config |
| examples/nuxt/package.json | Minor dependency order cleanup |
| examples/modern-js/package.json | Switches linting to oxlint/oxfmt and updates lint-staged config |
| examples/modern-js/biome.json | Removes Biome config |
| examples/mf-react-rsbuild/package.json | Switches Nx run-many to pnpm filter scripts |
| examples/mf-react-rsbuild/README.md | Removes Nx instructions |
| examples/lynx/package.json | Switches formatting from Prettier to Oxfmt |
| examples/lynx/.prettierrc | Removes Prettier config |
| examples/lynx/.prettierignore | Removes Prettier ignore file |
| examples/elysia-app/package.json | Minor dependency order cleanup |
| examples/astro-blog/package.json | Minor key reordering |
| eslint.config.mjs | Removes Nx ESLint flat config setup |
| e2e/deployment/tsconfig.spec.json | Switches spec types/includes to RStest |
| e2e/deployment/tsconfig.lib.json | Removes split lib tsconfig |
| e2e/deployment/tsconfig.json | Normalizes tsconfig to root tsconfig + composite build |
| e2e/deployment/src/index.test.ts | Replaces Nx affected discovery with turbo ls; adds local-cache skip behavior |
| e2e/deployment/rstest.config.ts | Adds RStest config for e2e package |
| e2e/deployment/project.json | Removes Nx project configuration |
| e2e/deployment/package.json | Switches scripts/deps to rstest + oxlint |
| e2e/deployment/jest.config.ts | Removes Jest config |
| e2e/deployment/eslint.config.mjs | Removes Nx-era ESLint config |
| e2e/deployment/README.md | Updates docs away from Nx (but still mentions Jest) |
| README.md | Updates repo description (Nx → Turborepo) and formatter name |
| .prettierrc | Removes Prettier config |
| .prettierignore | Removes Prettier ignore file |
| .oxlintrc.json | Adds Oxlint configuration |
| .oxfmtrc.json | Adds Oxfmt configuration |
| .husky/pre-commit | Switches pre-commit steps from Nx to turbo/ox* tooling |
| .github/workflows/publish_packages.yml | Updates build step from Nx run-many to pnpm build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Running tests | ||
|
|
||
| Run `nx test e2e-deployment` to execute the unit tests via [Jest](https://jestjs.io). | ||
| Run `pnpm --filter e2e-deployment test` to execute the tests via [Jest](https://jestjs.io). |
There was a problem hiding this comment.
The README still says the e2e tests run via Jest, but this PR migrates tests to RStest (new rstest.config.ts and rstest scripts). Update this line to reference RStest (and ideally link to the RStest docs) to avoid misleading instructions.
Suggested change
| Run `pnpm --filter e2e-deployment test` to execute the tests via [Jest](https://jestjs.io). | |
| Run `pnpm --filter e2e-deployment test` to execute the tests via [RStest](https://rstest.rs). |
| coverage: { | ||
| enabled: false, | ||
| provider: 'istanbul', | ||
| reportsDirectory: '../../coverage/apps/sample-rspack-application', |
There was a problem hiding this comment.
This reportsDirectory path is inconsistent with the other example packages (which use ../../coverage/examples/...). Even though coverage is currently disabled, keeping this consistent avoids confusing coverage output locations if coverage is later enabled.
Suggested change
| reportsDirectory: '../../coverage/apps/sample-rspack-application', | |
| reportsDirectory: '../../coverage/examples/sample-rspack-application', |
Comment on lines
+1
to
31
| import { describe, expect, test } from '@rstest/core'; | ||
| import { withZephyr } from './vite-plugin-zephyr'; | ||
|
|
||
| describe('vite-plugin-zephyr', () => { | ||
| test('withZephyr without mfConfig does not load module federation', () => { | ||
| jest.isolateModules(() => { | ||
| jest.doMock('vite', () => ({ | ||
| loadEnv: jest.fn(() => ({})), | ||
| })); | ||
| jest.doMock('@module-federation/vite', () => { | ||
| throw new Error('module federation should not load'); | ||
| }); | ||
|
|
||
| const { withZephyr } = require('./vite-plugin-zephyr') as { | ||
| withZephyr: () => Array<{ name?: string }>; | ||
| }; | ||
|
|
||
| const plugins = withZephyr(); | ||
| expect(plugins).toHaveLength(1); | ||
| expect(plugins[0]?.name).toBe('with-zephyr'); | ||
| }); | ||
| const plugins = withZephyr(); | ||
| expect(plugins).toHaveLength(1); | ||
| expect(plugins[0]?.name).toBe('with-zephyr'); | ||
| }); | ||
|
|
||
| test('withZephyr with mfConfig injects runtime plugin and delegates to mf plugin', () => { | ||
| jest.isolateModules(() => { | ||
| jest.doMock('vite', () => ({ | ||
| loadEnv: jest.fn(() => ({})), | ||
| })); | ||
| const federation = jest.fn((config) => [ | ||
| { | ||
| name: 'module-federation-vite', | ||
| _options: config, | ||
| }, | ||
| ]); | ||
|
|
||
| jest.doMock('@module-federation/vite', () => ({ | ||
| federation, | ||
| })); | ||
|
|
||
| const { withZephyr } = require('./vite-plugin-zephyr') as { | ||
| withZephyr: (options?: Record<string, unknown>) => Array<{ | ||
| name?: string; | ||
| _options?: { runtimePlugins?: string[] }; | ||
| }>; | ||
| }; | ||
|
|
||
| const plugins = withZephyr({ | ||
| mfConfig: { | ||
| name: 'host', | ||
| }, | ||
| }); | ||
| const plugins = withZephyr({ | ||
| mfConfig: { | ||
| name: 'host', | ||
| }, | ||
| }); | ||
|
|
||
| expect(federation).toHaveBeenCalledTimes(1); | ||
| expect(federation.mock.calls[0]?.[0]?.runtimePlugins).toEqual( | ||
| expect.arrayContaining(['virtual:zephyr-mf-runtime-plugin']) | ||
| ); | ||
| expect(plugins.map((plugin) => plugin.name)).toEqual([ | ||
| 'module-federation-vite', | ||
| 'with-zephyr', | ||
| ]); | ||
| const pluginNames = plugins.map((plugin) => plugin.name); | ||
| expect(pluginNames).toContain('module-federation-vite'); | ||
| expect(pluginNames.at(-1)).toBe('with-zephyr'); | ||
|
|
||
| const moduleFederationPlugin = plugins.find( | ||
| (plugin) => plugin.name === 'module-federation-vite' | ||
| ); | ||
| expect(moduleFederationPlugin).toMatchObject({ | ||
| _options: expect.objectContaining({ | ||
| runtimePlugins: expect.arrayContaining([ | ||
| 'virtual:zephyr-mf-runtime-plugin', | ||
| ]), | ||
| }), | ||
| }); |
There was a problem hiding this comment.
These tests no longer assert the key behavior they describe: (1) the first test doesn't verify that module federation was not loaded/called, it only checks the returned plugin list length/name; (2) the second test relies on a non-public _options field on the returned federation plugin, which is brittle across dependency versions. Consider restoring module isolation/mocking (e.g., mock @module-federation/vite and assert it was not invoked without mfConfig, and was invoked with runtimePlugins containing virtual:zephyr-mf-runtime-plugin when mfConfig is provided).
Comment on lines
63
to
76
| it( | ||
| 'should have correctly deployed assets', | ||
| async () => { | ||
| if (!hasDeploymentCache) { | ||
| return; | ||
| } | ||
|
|
||
| if (!deployResult) { | ||
| throw new Error( | ||
| `No deployment log loaded for application ${appName}.` | ||
| ); | ||
| } | ||
|
|
||
| const url = deployResult.urls[0]; |
There was a problem hiding this comment.
Returning early here makes the test silently pass when hasDeploymentCache is false, which can hide regressions (especially for local runs where you likely want an explicit signal that e2e assertions were skipped). Prefer explicitly skipping the test (e.g., conditionally defining an it.skip(...) / test.skip(...)) or marking it as pending, so the test output clearly indicates it didn't run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nx.json,project.json, Nx/Jest config pattern)turbo.jsonand workspace script updatestsgotsconfig.jsonusage with root references/global settingszephyr-agentsuites under the new test runtimeValidation
pnpm -s testpassespnpm --filter zephyr-agent testpassesNotes
.cursor/mcp.jsonintentionally excluded from commit--no-verifybecause current pre-commit lint reports unrelated existing issues inzephyr-agenttests